[nautilus/wip/gbsneto/cleanups: 5/5] window: remove old hack



commit 5559958456fc15fd9eeaab0987b11bbd519152a4
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Wed Jul 29 19:47:03 2015 -0300

    window: remove old hack
    
    NautilusWindow immediately displays the newly opened
    tab or window and, for that to happen correctly, an
    old hack is present.
    
    This hack, however, added some unecessary complexity to
    NautilusWindow code, and is completely obsolete nowadays.
    It was needed to fix bug 679640, but seems like the real
    cause of the bug was fixed and this hack does nothing,
    appearently.
    
    Remove the old hack and lets see if will continue to behave
    properly.

 src/nautilus-window.c |   21 ---------------------
 1 files changed, 0 insertions(+), 21 deletions(-)
---
diff --git a/src/nautilus-window.c b/src/nautilus-window.c
index 1b8d9d0..48c0c35 100644
--- a/src/nautilus-window.c
+++ b/src/nautilus-window.c
@@ -2253,27 +2253,6 @@ nautilus_window_view_visible (NautilusWindow *window,
 
        g_return_if_fail (NAUTILUS_IS_WINDOW (window));
 
-       /* FIXME: this code is odd and should not really be needed, but
-        * removing it causes bugs, see e.g.
-        * https://bugzilla.gnome.org/show_bug.cgi?id=679640
-        *
-        * Needs more investigation...
-        */
-       slot = nautilus_view_get_nautilus_window_slot (view);
-       if (g_object_get_data (G_OBJECT (slot), "nautilus-window-view-visible") != NULL) {
-               return;
-       }
-
-       g_object_set_data (G_OBJECT (slot), "nautilus-window-view-visible", GINT_TO_POINTER (1));
-
-       /* Look for other non-visible slots */
-       for (l = window->priv->slots; l != NULL; l = l->next) {
-               slot = l->data;
-               if (g_object_get_data (G_OBJECT (slot), "nautilus-window-view-visible") == NULL) {
-                       return;
-               }
-       }
-
        /* Look for other non-visible slots */
        for (l = window->priv->slots; l != NULL; l = l->next) {
                slot = l->data;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]