[network-manager-applet/th/vpn-plugin-info-bgo749877: 2/2] TODO: vpn: fix set_up_connection_type_combo() for vpn types



commit e8bc282ea4729a4eb14a156e556a5bb10c03511c
Author: Lubomir Rintel <lkundrak v3 sk>
Date:   Fri Jul 24 16:52:14 2015 +0200

    TODO: vpn: fix set_up_connection_type_combo() for vpn types
    
    [thaller: I don't think this is correct. Looking at the
     history, with libnm-glib we used NM_VPN_PLUGIN_UI_INTERFACE_NAME --
     which is NM_VPN_EDITOR_PLUGIN_NAME and not
     NM_VPN_EDITOR_PLUGIN_DESCRIPTION.
     And if we would use the description,  _sort_vpn_plugins() should
     sort the plugins according to their description too, not their
     long-name.]
    
    Fixes: 4d7546e7d0e56c3a102a12ba03695eac6f8109f8

 src/connection-editor/connection-helpers.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/connection-editor/connection-helpers.c b/src/connection-editor/connection-helpers.c
index ed2cd52..b80a48e 100644
--- a/src/connection-editor/connection-helpers.c
+++ b/src/connection-editor/connection-helpers.c
@@ -266,7 +266,7 @@ set_up_connection_type_combo (GtkComboBox *combo,
                NMVpnEditorPlugin *plugin = nm_vpn_plugin_info_get_editor_plugin (p->data);
                char *desc;
 
-               g_object_get (plugin, NM_VPN_EDITOR_PLUGIN_NAME, &desc, NULL);
+               g_object_get (plugin, NM_VPN_EDITOR_PLUGIN_DESCRIPTION, &desc, NULL);
 
                if (show_headers)
                        markup = g_markup_printf_escaped ("    %s", desc);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]