[gtkmm] Gtk::PlacesSidebar: Add set_drop_targets_visible()



commit 3b05372e74cc8bd05b7c3e1a0e51efd2fb399c52
Author: Kjell Ahlstedt <kjell ahlstedt bredband net>
Date:   Tue Jul 28 18:52:34 2015 +0200

    Gtk::PlacesSidebar: Add set_drop_targets_visible()
    
    * gtk/src/placessidebar.hg: Add set_drop_targets_visible().
    Update deprecation messages for set/get_show_connect_to_server().

 gtk/src/placessidebar.hg |   17 +++++++----------
 1 files changed, 7 insertions(+), 10 deletions(-)
---
diff --git a/gtk/src/placessidebar.hg b/gtk/src/placessidebar.hg
index 5113df7..de230d4 100644
--- a/gtk/src/placessidebar.hg
+++ b/gtk/src/placessidebar.hg
@@ -67,8 +67,8 @@ public:
 
   /** Creates a new Gtk::PlacesSidebar widget.
    *
-   * The application should connect to at least the "open-location" signal to be notified when the user 
makes a selection in the sidebar.
-   *
+   * The application should connect to at least the "open-location" signal
+   * to be notified when the user makes a selection in the sidebar.
    */
   _CTOR_DEFAULT
 
@@ -98,9 +98,9 @@ public:
   _WRAP_METHOD(Glib::RefPtr<Gio::File> get_nth_bookmark(int n) const, gtk_places_sidebar_get_nth_bookmark)
 
   _WRAP_METHOD(void set_show_connect_to_server(bool show_connect_to_server = true), 
gtk_places_sidebar_set_show_connect_to_server,
-               deprecated "Use set_show_other_locations() instead.")
+    deprecated "It is recommended to group this functionality with the drives and network location under the 
new 'Other Location' item.")
   _WRAP_METHOD(bool get_show_connect_to_server() const, gtk_places_sidebar_get_show_connect_to_server,
-               deprecated "Use get_show_other_locations() instead.")
+    deprecated "It is recommended to group this functionality with the drives and network location under the 
new 'Other Location' item.")
 
   _WRAP_METHOD(void set_local_only(bool local_only = true), gtk_places_sidebar_set_local_only)
   _WRAP_METHOD(bool get_local_only() const, gtk_places_sidebar_get_local_only)
@@ -117,12 +117,9 @@ public:
   _WRAP_METHOD(void set_show_other_locations(bool show_other_locations = true), 
gtk_places_sidebar_set_show_other_locations)
   _WRAP_METHOD(bool get_show_other_locations() const, gtk_places_sidebar_get_show_other_locations)
 
-  //TODO: Don't know how to best wrap gtk_places_sidebar_set_drop_targets_visible(). /Kjell
-  //_WRAP_METHOD(void set_drop_targets_visible(bool visible, const Glib::RefPtr<Gdk::DragContext>& context), 
gtk_places_sidebar_set_drop_targets_visible)
-  // If visible is false, context is not used, but the documentation does not say so (2015-07-19).
-  // If that's properly documented in gtk+, an alternative wrapping would be:
-  //void set_drop_targets_visible(const Glib::RefPtr<Gdk::DragContext>& context);
-  //void unset_drop_targets_visible();
+  // Gtk+ does not guarantee that context can be a nullptr, not even when visible is false.
+  // See https://bugzilla.gnome.org/show_bug.cgi?id=752633#c3.
+  _WRAP_METHOD(void set_drop_targets_visible(bool visible, const Glib::RefPtr<Gdk::DragContext>& context), 
gtk_places_sidebar_set_drop_targets_visible)
 
 
 // We use no_default_handler with _WRAP_SIGNAL because the C *Class struct is hidden for GtkPlacesSidebar.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]