[nautilus] window-slot: clarify comment about races on done_loading
- From: Carlos Soriano Sánchez <csoriano src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [nautilus] window-slot: clarify comment about races on done_loading
- Date: Thu, 23 Jul 2015 21:23:11 +0000 (UTC)
commit cbc4759bfc6df5748b7fa2905201a2a8d8697803
Author: Carlos Soriano <csoriano gnome org>
Date: Thu Jul 23 23:22:00 2015 +0200
window-slot: clarify comment about races on done_loading
src/nautilus-window-slot.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
---
diff --git a/src/nautilus-window-slot.c b/src/nautilus-window-slot.c
index 43d50a2..7a6036b 100644
--- a/src/nautilus-window-slot.c
+++ b/src/nautilus-window-slot.c
@@ -217,6 +217,10 @@ nautilus_window_slot_on_done_loading (NautilusDirectory *directory,
slot->details->busy = FALSE;
remove_loading_floating_bar (slot);
+ /* For this pourpose, we could check directly to see if the view is empty,
+ * instead of avoiding races disconnecting the model when appropiate.
+ * But I think we are doing better disconnecting when we know the data
+ * of the directory is not valid */
if (g_list_length (files) != 0) {
gtk_widget_hide (slot->details->no_search_results_widget);
} else {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]