[gtk+/gtk-3-16] gtkicontheme: Check a return value
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+/gtk-3-16] gtkicontheme: Check a return value
- Date: Fri, 17 Jul 2015 20:12:46 +0000 (UTC)
commit 64affb0406dd3ce0f54c60d80524848fca94bb9c
Author: Matthias Clasen <mclasen redhat com>
Date: Fri Jul 17 15:54:40 2015 -0400
gtkicontheme: Check a return value
We were already looking at the error anyway, but rewriting things
this way lets coverity see the light.
gtk/gtkicontheme.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
---
diff --git a/gtk/gtkicontheme.c b/gtk/gtkicontheme.c
index ebacbf0..d3a26a2 100644
--- a/gtk/gtkicontheme.c
+++ b/gtk/gtkicontheme.c
@@ -1158,8 +1158,7 @@ insert_theme (GtkIconTheme *icon_theme,
{
theme_file = g_key_file_new ();
g_key_file_set_list_separator (theme_file, ',');
- g_key_file_load_from_file (theme_file, path, 0, &error);
- if (error)
+ if (!g_key_file_load_from_file (theme_file, path, 0, &error))
{
g_key_file_free (theme_file);
theme_file = NULL;
@@ -4099,7 +4098,7 @@ load_icon_thread (GTask *task,
{
GtkIconInfo *dup = task_data;
- icon_info_ensure_scale_and_pixbuf (dup);
+ (void)icon_info_ensure_scale_and_pixbuf (dup);
g_task_return_pointer (task, NULL, NULL);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]