[gnome-panel/wip/segeiger/panel-add-to-dialog: 1/2] Implement composite template and widget class



commit 62d0514ea5a044f10648b4c7f9a4954ae791a98f
Author: Sebastian Geiger <sbastig gmx net>
Date:   Thu Jul 16 22:03:32 2015 +0200

    Implement composite template and widget class

 gnome-panel/panel-add-to-dialog.ui |   23 ++-
 gnome-panel/panel-addto.c          |  321 ++++++++++++++++--------------------
 gnome-panel/panel-addto.h          |    8 +-
 gnome-panel/panel.gresource.xml    |    1 +
 4 files changed, 164 insertions(+), 189 deletions(-)
---
diff --git a/gnome-panel/panel-add-to-dialog.ui b/gnome-panel/panel-add-to-dialog.ui
index a4595bc..58b3db5 100644
--- a/gnome-panel/panel-add-to-dialog.ui
+++ b/gnome-panel/panel-add-to-dialog.ui
@@ -10,7 +10,7 @@
       <column type="gchararray"/>
     </columns>
   </object>
-  <template class="PanelAddToWindow" parent="GtkWindow">
+  <template class="PanelAddtoDialog" parent="GtkWindow">
     <property name="can_focus">False</property>
     <property name="border_width">5</property>
     <property name="title" translatable="yes">Add to Panel</property>
@@ -67,7 +67,7 @@
               </packing>
             </child>
             <child>
-              <object class="GtkScrolledWindow" id="scrolledwindow1">
+              <object class="GtkScrolledWindow" id="scrolled_window">
                 <property name="visible">True</property>
                 <property name="can_focus">True</property>
                 <property name="shadow_type">in</property>
@@ -79,13 +79,17 @@
                     <property name="headers_visible">False</property>
                     <property name="search_column">1</property>
                     <child internal-child="selection">
-                      <object class="GtkTreeSelection" id="treeview-selection1"/>
+                      <object class="GtkTreeSelection" id="tree_view_selection"/>
                     </child>
                     <child>
-                      <object class="GtkTreeViewColumn" id="treeviewcolumn1">
+                      <object class="GtkTreeViewColumn" id="tree_view_column_icon">
                         <property name="title" translatable="yes">column</property>
                         <child>
-                          <object class="GtkCellRendererPixbuf" id="cellrendererpixbuf1"/>
+                          <object class="GtkCellRendererPixbuf" id="cellrendererpixbuf1">
+                            <property name="xpad">4</property>
+                            <property name="ypad">4</property>
+                            <property name="stock_size">5</property>
+                          </object>
                           <attributes>
                             <attribute name="gicon">0</attribute>
                           </attributes>
@@ -93,14 +97,15 @@
                       </object>
                     </child>
                     <child>
-                      <object class="GtkTreeViewColumn" id="treeviewcolumn2">
+                      <object class="GtkTreeViewColumn" id="tree_view_column_text">
                         <property name="sizing">fixed</property>
                         <property name="title" translatable="yes">column</property>
                         <child>
-                          <object class="GtkCellRendererText" id="cellrenderertext1"/>
+                          <object class="GtkCellRendererText" id="cellrenderertext1">
+                            <property name="ellipsize">end</property>
+                          </object>
                           <attributes>
-                            <attribute name="ellipsize">1</attribute>
-                            <attribute name="text">1</attribute>
+                            <attribute name="markup">1</attribute>
                           </attributes>
                         </child>
                       </object>
diff --git a/gnome-panel/panel-addto.c b/gnome-panel/panel-addto.c
index aeada98..4ea8100 100644
--- a/gnome-panel/panel-addto.c
+++ b/gnome-panel/panel-addto.c
@@ -23,7 +23,9 @@
 #include <config.h>
 #include <string.h>
 
+#include <gtk/gtk.h>
 #include <glib/gi18n.h>
+#include <glib-object.h>
 
 #include <gmenu-tree.h>
 
@@ -47,15 +49,24 @@
 #include "panel-icon-names.h"
 #include "panel-user-menu.h"
 
-typedef struct {
+#include "panel-addto.h"
+
+#include <libgen.h>
+#define DEBUG_FUNCTION(NAME) g_printerr("%s: FUNCTION ENTERED: %s\n", basename(__FILE__), (NAME))
+
+struct _PanelAddtoDialog {
+       GtkWindow    parent;
        PanelWidget *panel_widget;
 
-       GtkWidget    *addto_dialog;
+       GtkWidget    *dialog_vbox;
        GtkWidget    *label;
        GtkWidget    *search_entry;
-       GtkWidget    *back_button;
-       GtkWidget    *add_button;
+       GtkWidget    *button_back;
+       GtkWidget    *button_add;
+       GtkWidget    *button_close;
        GtkWidget    *tree_view;
+       GtkWidget    *tree_view_selection;
+
        GtkTreeModel *applet_model;
        GtkTreeModel *filter_applet_model;
        GtkTreeModel *application_model;
@@ -70,10 +81,12 @@ typedef struct {
        gchar        *search_text;
        gchar        *applet_search_text;
 
-       guint         name_notify;
+       gulong        name_notify;
 
        PanelObjectPackType insert_pack_type;
-} PanelAddtoDialog;
+};
+
+G_DEFINE_TYPE (PanelAddtoDialog, panel_addto_dialog, GTK_TYPE_WINDOW)
 
 static GQuark panel_addto_dialog_quark = 0;
 
@@ -795,54 +808,45 @@ panel_addto_add_item (PanelAddtoDialog   *dialog,
 }
 
 static void
-panel_addto_dialog_response (GtkWidget *widget_dialog,
-                            guint response_id,
-                            PanelAddtoDialog *dialog)
+panel_addto_dialog_button_add (GtkWidget *widget,
+                               PanelAddtoDialog *dialog)
 {
        GtkTreeSelection *selection;
-       GtkTreeModel     *filter_model;
-       GtkTreeModel     *child_model;
-       GtkTreeIter       iter;
-       GtkTreeIter       filter_iter;
-
-       switch (response_id) {
-       case PANEL_ADDTO_RESPONSE_ADD:
-               selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (dialog->tree_view));
-               if (gtk_tree_selection_get_selected (selection, &filter_model,
-                                                    &filter_iter)) {
-                       PanelAddtoItemInfo *data;
-
-                       gtk_tree_model_filter_convert_iter_to_child_iter (GTK_TREE_MODEL_FILTER 
(filter_model),
-                                                                         &iter,
-                                                                         &filter_iter);
-                       child_model = gtk_tree_model_filter_get_model (GTK_TREE_MODEL_FILTER (filter_model));
-                       gtk_tree_model_get (child_model, &iter,
-                                           COLUMN_DATA, &data, -1);
-
-                       if (data != NULL)
-                               panel_addto_add_item (dialog, data);
-               }
-               break;
-
-       case PANEL_ADDTO_RESPONSE_BACK:
-               /* This response only happens when we're showing the
-                * application list and the user wants to go back to the
-                * applet list. */
-               panel_addto_present_applets (dialog);
-               break;
+       GtkTreeModel *filter_model;
+       GtkTreeModel *child_model;
+       GtkTreeIter iter;
+       GtkTreeIter filter_iter;
 
-       case GTK_RESPONSE_CLOSE:
-               gtk_widget_destroy (widget_dialog);
-               break;
 
-       default:
-               break;
+       selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (dialog->tree_view));
+       if (gtk_tree_selection_get_selected (selection, &filter_model,
+                                                                                &filter_iter)) {
+               PanelAddtoItemInfo *data;
+
+               gtk_tree_model_filter_convert_iter_to_child_iter (GTK_TREE_MODEL_FILTER (filter_model),
+                                                                                                             
    &iter,
+                                                                                                             
    &filter_iter);
+               child_model = gtk_tree_model_filter_get_model (GTK_TREE_MODEL_FILTER (filter_model));
+               gtk_tree_model_get (child_model, &iter,
+                                                       COLUMN_DATA, &data, -1);
+
+               if (data != NULL)
+                       panel_addto_add_item (dialog, data);
        }
 }
 
 static void
-panel_addto_dialog_destroy (GtkWidget *widget_dialog,
-                           PanelAddtoDialog *dialog)
+panel_addto_dialog_button_back (GtkWidget *widget,
+                               PanelAddtoDialog *dialog)
+{
+       /* This response only happens when we're showing the
+        * application list and the user wants to go back to the
+        * applet list. */
+       panel_addto_present_applets (dialog);
+}
+
+static void
+panel_addto_dialog_destroy (PanelAddtoDialog *dialog)
 {
        panel_toplevel_pop_autohide_disabler (PANEL_TOPLEVEL (dialog->panel_widget->toplevel));
        g_object_set_qdata (G_OBJECT (dialog->panel_widget->toplevel),
@@ -851,15 +855,21 @@ panel_addto_dialog_destroy (GtkWidget *widget_dialog,
 }
 
 static void
+panel_addto_dialog_button_close (GtkWidget        *widget,
+                                                                PanelAddtoDialog *dialog) {
+       panel_addto_dialog_destroy (dialog);
+}
+
+static void
 panel_addto_present_applications (PanelAddtoDialog *dialog)
 {
        if (dialog->filter_application_model == NULL)
                panel_addto_make_application_model (dialog);
        gtk_tree_view_set_model (GTK_TREE_VIEW (dialog->tree_view),
                                 dialog->filter_application_model);
-       gtk_window_set_focus (GTK_WINDOW (dialog->addto_dialog),
+       gtk_window_set_focus (GTK_WINDOW (dialog),
                              dialog->search_entry);
-       gtk_widget_set_sensitive (dialog->back_button, TRUE);
+       gtk_widget_set_sensitive (dialog->button_back, TRUE);
 
        if (dialog->applet_search_text)
                g_free (dialog->applet_search_text);
@@ -876,9 +886,9 @@ panel_addto_present_applets (PanelAddtoDialog *dialog)
                panel_addto_make_applet_model (dialog);
        gtk_tree_view_set_model (GTK_TREE_VIEW (dialog->tree_view),
                                 dialog->filter_applet_model);
-       gtk_window_set_focus (GTK_WINDOW (dialog->addto_dialog),
+       gtk_window_set_focus (GTK_WINDOW (dialog),
                              dialog->search_entry);
-       gtk_widget_set_sensitive (dialog->back_button, FALSE);
+       gtk_widget_set_sensitive (dialog->button_back, FALSE);
 
        if (dialog->applet_search_text) {
                gtk_entry_set_text (GTK_ENTRY (dialog->search_entry),
@@ -968,9 +978,8 @@ panel_addto_dialog_free (PanelAddtoDialog *dialog)
                g_free (dialog->applet_search_text);
        dialog->applet_search_text = NULL;
 
-       if (dialog->addto_dialog)
-               gtk_widget_destroy (dialog->addto_dialog);
-       dialog->addto_dialog = NULL;
+
+       gtk_widget_destroy (GTK_WIDGET (dialog));
 
        for (item = dialog->applet_list; item != NULL; item = item->next) {
                PanelAddtoItemInfo *applet;
@@ -1023,9 +1032,6 @@ panel_addto_name_change (PanelAddtoDialog *dialog)
        if (label == NULL)
                label = g_strdup (_("Find an _item to add to the panel:"));
 
-       gtk_window_set_title (GTK_WINDOW (dialog->addto_dialog),
-                             _("Add to Panel"));
-
        gtk_label_set_text_with_mnemonic (GTK_LABEL (dialog->label), label);
        g_free (label);
 }
@@ -1109,8 +1115,9 @@ static void
 panel_addto_search_entry_activated (GtkWidget        *entry,
                                    PanelAddtoDialog *dialog)
 {
-       gtk_dialog_response (GTK_DIALOG (dialog->addto_dialog),
-                            PANEL_ADDTO_RESPONSE_ADD);
+       /* FIXME: activate add button callback */
+/*     gtk_dialog_response (GTK_DIALOG (dialog->addto_dialog),
+                                                PANEL_ADDTO_RESPONSE_ADD);*/
 }
 
 static void
@@ -1127,7 +1134,7 @@ panel_addto_selection_changed (GtkTreeSelection *selection,
        if (!gtk_tree_selection_get_selected (selection,
                                              &filter_model,
                                              &filter_iter)) {
-               gtk_widget_set_sensitive (GTK_WIDGET (dialog->add_button),
+               gtk_widget_set_sensitive (GTK_WIDGET (dialog->button_add),
                                          FALSE);
                return;
        }
@@ -1138,18 +1145,18 @@ panel_addto_selection_changed (GtkTreeSelection *selection,
        gtk_tree_model_get (child_model, &iter, COLUMN_DATA, &data, -1);
 
        if (!data) {
-               gtk_widget_set_sensitive (GTK_WIDGET (dialog->add_button),
+               gtk_widget_set_sensitive (GTK_WIDGET (dialog->button_add),
                                          FALSE);
                return;
        }
 
-       gtk_widget_set_sensitive (GTK_WIDGET (dialog->add_button), TRUE);
+       gtk_widget_set_sensitive (GTK_WIDGET (dialog->button_add), TRUE);
 
        if (data->type == PANEL_ADDTO_LAUNCHER_MENU) {
-               gtk_button_set_label (GTK_BUTTON (dialog->add_button),
+               gtk_button_set_label (GTK_BUTTON (dialog->button_add),
                                      _("_Forward"));
        } else {
-               gtk_button_set_label (GTK_BUTTON (dialog->add_button),
+               gtk_button_set_label (GTK_BUTTON (dialog->button_add),
                                      _("_Add"));
        }
 
@@ -1194,8 +1201,9 @@ panel_addto_selection_activated (GtkTreeView       *view,
                                 GtkTreeViewColumn *column,
                                 PanelAddtoDialog  *dialog)
 {
-       gtk_dialog_response (GTK_DIALOG (dialog->addto_dialog),
-                            PANEL_ADDTO_RESPONSE_ADD);
+       /* FIXME: activate add button callback */
+       /*gtk_dialog_response (GTK_DIALOG (dialog->addto_dialog),
+                            PANEL_ADDTO_RESPONSE_ADD);*/
 }
 
 static gboolean
@@ -1218,16 +1226,10 @@ panel_addto_separator_func (GtkTreeModel *model,
 static PanelAddtoDialog *
 panel_addto_dialog_new (PanelWidget *panel_widget)
 {
+       DEBUG_FUNCTION ("panel_addto_dialog_new");
        PanelAddtoDialog *dialog;
-       GtkWidget *dialog_vbox;
-       GtkWidget *inner_vbox;
-       GtkWidget *find_hbox;
-       GtkWidget *sw;
-       GtkCellRenderer *renderer;
-       GtkTreeSelection *selection;
-       GtkTreeViewColumn *column;
 
-       dialog = g_new0 (PanelAddtoDialog, 1);
+       dialog = g_object_new (PANEL_TYPE_ADDTO_DIALOG, NULL);
 
        g_object_set_qdata_full (G_OBJECT (panel_widget->toplevel),
                                 panel_addto_dialog_quark,
@@ -1241,132 +1243,95 @@ panel_addto_dialog_new (PanelWidget *panel_widget)
                                  G_CALLBACK (panel_addto_name_notify),
                                  dialog);
 
-       dialog->addto_dialog = gtk_dialog_new ();
-       dialog->back_button = gtk_dialog_add_button (GTK_DIALOG (dialog->addto_dialog),
-                                                    _("_Back"),
-                                                    PANEL_ADDTO_RESPONSE_BACK);
-       dialog->add_button = gtk_dialog_add_button (GTK_DIALOG (dialog->addto_dialog),
-                                                    _("_Add"),
-                                                    PANEL_ADDTO_RESPONSE_ADD);
-       gtk_dialog_add_button (GTK_DIALOG (dialog->addto_dialog),
-                              _("_Close"),
-                              GTK_RESPONSE_CLOSE);
-       gtk_widget_set_sensitive (GTK_WIDGET (dialog->add_button), FALSE);
-       gtk_dialog_set_default_response (GTK_DIALOG (dialog->addto_dialog),
-                                        PANEL_ADDTO_RESPONSE_ADD);
-
-       gtk_container_set_border_width (GTK_CONTAINER (dialog->addto_dialog), 5);
-
-       dialog_vbox = gtk_dialog_get_content_area (GTK_DIALOG (dialog->addto_dialog));
-       gtk_box_set_spacing (GTK_BOX (dialog_vbox), 12);
-       gtk_container_set_border_width (GTK_CONTAINER (dialog_vbox), 5);
-
-       g_signal_connect (G_OBJECT (dialog->addto_dialog), "response",
-                         G_CALLBACK (panel_addto_dialog_response), dialog);
-       g_signal_connect (dialog->addto_dialog, "destroy",
-                         G_CALLBACK (panel_addto_dialog_destroy), dialog);
-
-       inner_vbox = gtk_box_new (GTK_ORIENTATION_VERTICAL, 6);
-       gtk_box_pack_start (GTK_BOX (dialog_vbox), inner_vbox, TRUE, TRUE, 0);
-
-       find_hbox = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 6);
-       gtk_box_pack_start (GTK_BOX (inner_vbox), find_hbox, FALSE, FALSE, 0);
-
-       dialog->label = gtk_label_new_with_mnemonic ("");
-       gtk_label_set_xalign (GTK_LABEL (dialog->label), 0.0);
-       gtk_label_set_use_markup (GTK_LABEL (dialog->label), TRUE);
-
-       gtk_box_pack_start (GTK_BOX (find_hbox), dialog->label,
-                           FALSE, FALSE, 0);
-
-       dialog->search_entry = gtk_entry_new (); 
-       g_signal_connect (G_OBJECT (dialog->search_entry), "changed",
-                         G_CALLBACK (panel_addto_search_entry_changed), dialog);
-       g_signal_connect (G_OBJECT (dialog->search_entry), "activate",
-                         G_CALLBACK (panel_addto_search_entry_activated), dialog);
+       gtk_widget_show_all (dialog->dialog_vbox);
 
-       gtk_box_pack_end (GTK_BOX (find_hbox), dialog->search_entry,
-                         TRUE, TRUE, 0);
+       panel_toplevel_push_autohide_disabler (dialog->panel_widget->toplevel);
+       panel_widget_register_open_dialog (panel_widget,
+                                          GTK_WIDGET (dialog));
 
-       gtk_label_set_mnemonic_widget (GTK_LABEL (dialog->label),
-                                      dialog->search_entry);
+       panel_addto_name_change (dialog);
 
-       sw = gtk_scrolled_window_new (NULL, NULL);
-       gtk_scrolled_window_set_policy (GTK_SCROLLED_WINDOW (sw),
-                                       GTK_POLICY_AUTOMATIC,
-                                       GTK_POLICY_AUTOMATIC);
-       gtk_scrolled_window_set_shadow_type (GTK_SCROLLED_WINDOW (sw),
-                                            GTK_SHADOW_IN);
-       gtk_box_pack_start (GTK_BOX (inner_vbox), sw, TRUE, TRUE, 0);
+       return dialog;
+}
 
-       dialog->tree_view = gtk_tree_view_new ();
-       gtk_tree_view_set_headers_visible (GTK_TREE_VIEW (dialog->tree_view),
-                                          FALSE);
+static void
+panel_addto_dialog_constructed (GObject *object)
+{
+       G_OBJECT_CLASS (panel_addto_dialog_parent_class)->constructed (object);
+       PanelAddtoDialog *dialog = PANEL_ADDTO_DIALOG (object);
+
+       g_signal_connect (G_OBJECT (dialog), "destroy",
+                                         G_CALLBACK (panel_addto_dialog_destroy), dialog);
+       g_signal_connect (dialog->button_add, "clicked", G_CALLBACK (panel_addto_dialog_button_add), dialog);
+       g_signal_connect (dialog->button_back, "clicked", G_CALLBACK (panel_addto_dialog_button_back), 
dialog);
+       g_signal_connect (dialog->button_close, "clicked", G_CALLBACK (panel_addto_dialog_button_close), 
dialog);
+       g_signal_connect (G_OBJECT (dialog->search_entry), "changed",
+                                         G_CALLBACK (panel_addto_search_entry_changed), dialog);
+       g_signal_connect (G_OBJECT (dialog->search_entry), "activate",
+                                         G_CALLBACK (panel_addto_search_entry_activated), dialog);
+
+       /* Not sure if this can be removed or if there needs for some reason? */
        gtk_tree_view_expand_all (GTK_TREE_VIEW (dialog->tree_view));
 
-       renderer = g_object_new (GTK_TYPE_CELL_RENDERER_PIXBUF,
-                                "xpad", 4,
-                                "ypad", 4,
-                                "stock-size", GTK_ICON_SIZE_DND,
-                                NULL);
-
-       gtk_tree_view_insert_column_with_attributes (GTK_TREE_VIEW (dialog->tree_view),
-                                                    -1, NULL,
-                                                    renderer,
-                                                    "gicon", COLUMN_ICON,
-                                                    NULL);
-       renderer = gtk_cell_renderer_text_new ();
-       g_object_set (renderer, "ellipsize", PANGO_ELLIPSIZE_END, NULL);
-       gtk_tree_view_insert_column_with_attributes (GTK_TREE_VIEW (dialog->tree_view),
-                                                    -1, NULL,
-                                                    renderer,
-                                                    "markup", COLUMN_TEXT,
-                                                    NULL);
-
-       //FIXME use the same search than the one for the search entry?
+       /*FIXME use the same search than the one for the search entry? */
        gtk_tree_view_set_search_column (GTK_TREE_VIEW (dialog->tree_view),
-                                        COLUMN_SEARCH);
+                                                                        COLUMN_SEARCH);
 
        gtk_tree_view_set_row_separator_func (GTK_TREE_VIEW (dialog->tree_view),
                                              panel_addto_separator_func,
                                              GINT_TO_POINTER (COLUMN_TEXT),
                                              NULL);
-                                             
 
-       selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (dialog->tree_view));
-       gtk_tree_selection_set_mode (selection, GTK_SELECTION_SINGLE);
-
-       column = gtk_tree_view_get_column (GTK_TREE_VIEW (dialog->tree_view),
-                                          COLUMN_TEXT);
-       gtk_tree_view_column_set_sizing (column, GTK_TREE_VIEW_COLUMN_FIXED);
-
-       g_signal_connect (selection, "changed",
-                         G_CALLBACK (panel_addto_selection_changed),
-                         dialog);
+       g_signal_connect (dialog->tree_view_selection, "changed",
+                                         G_CALLBACK (panel_addto_selection_changed),
+                                         dialog);
 
        g_signal_connect (dialog->tree_view, "row-activated",
-                         G_CALLBACK (panel_addto_selection_activated),
-                         dialog);
-
-       gtk_container_add (GTK_CONTAINER (sw), dialog->tree_view);
-
-       gtk_widget_show_all (dialog_vbox);
+                                         G_CALLBACK (panel_addto_selection_activated),
+                                         dialog);
 
-       panel_toplevel_push_autohide_disabler (dialog->panel_widget->toplevel);
-       panel_widget_register_open_dialog (panel_widget,
-                                          dialog->addto_dialog);
+       /* FIXME: Do more widget instantiation */
+}
 
-       panel_addto_name_change (dialog);
+static void
+panel_addto_dialog_dispose (GObject *object)
+{
+       DEBUG_FUNCTION ("panel_addto_dialog_dispose");
+       /* FIXME: Do anything to dispose the dialog... */
+       G_OBJECT_CLASS (panel_addto_dialog_parent_class)->dispose (object);
+}
 
-       return dialog;
+static void
+panel_addto_dialog_class_init (PanelAddtoDialogClass *dialog_class) {
+       DEBUG_FUNCTION ("panel_addto_dialog_class_init");
+       GtkWidgetClass *widget_class = GTK_WIDGET_CLASS (dialog_class);
+       GObjectClass   *object_class = G_OBJECT_CLASS (dialog_class);
+
+       object_class->constructed = panel_addto_dialog_constructed;
+       object_class->dispose = panel_addto_dialog_dispose;
+
+       gtk_widget_class_set_template_from_resource (widget_class, "/org/gnome/panel/panel-add-to-dialog.ui");
+
+       gtk_widget_class_bind_template_child (widget_class, PanelAddtoDialog, dialog_vbox);
+       gtk_widget_class_bind_template_child (widget_class, PanelAddtoDialog, label);
+       gtk_widget_class_bind_template_child (widget_class, PanelAddtoDialog, search_entry);
+       gtk_widget_class_bind_template_child (widget_class, PanelAddtoDialog, button_add);
+       gtk_widget_class_bind_template_child (widget_class, PanelAddtoDialog, button_back);
+       gtk_widget_class_bind_template_child (widget_class, PanelAddtoDialog, button_close);
+       gtk_widget_class_bind_template_child (widget_class, PanelAddtoDialog, tree_view);
+       gtk_widget_class_bind_template_child (widget_class, PanelAddtoDialog, tree_view_selection);
 }
 
-#define MAX_ADDTOPANEL_HEIGHT 490
+static void panel_addto_dialog_init (PanelAddtoDialog *dialog) {
+       DEBUG_FUNCTION ("panel_addto_dialog_init");
+       gtk_widget_init_template (GTK_WIDGET (dialog));
+}
 
 void
 panel_addto_present (GtkMenuItem *item,
                     PanelWidget *panel_widget)
 {
+       DEBUG_FUNCTION ("panel_addto_present");
        PanelAddtoDialog *dialog;
        PanelToplevel *toplevel;
        PanelData     *pd;
@@ -1386,7 +1351,7 @@ panel_addto_present (GtkMenuItem *item,
 
        screen = gtk_window_get_screen (GTK_WINDOW (toplevel));
        screen_height = gdk_screen_get_height (screen);
-       height = MIN (MAX_ADDTOPANEL_HEIGHT, 3 * (screen_height / 4));
+       height = 3 * (screen_height / 4);
 
        if (!dialog) {
                dialog = panel_addto_dialog_new (panel_widget);
@@ -1394,8 +1359,8 @@ panel_addto_present (GtkMenuItem *item,
        }
 
        dialog->insert_pack_type = pd ? pd->insert_pack_type : PANEL_OBJECT_PACK_START;
-       gtk_window_set_screen (GTK_WINDOW (dialog->addto_dialog), screen);
-       gtk_window_set_default_size (GTK_WINDOW (dialog->addto_dialog),
+       gtk_window_set_screen (GTK_WINDOW (dialog), screen);
+       gtk_window_set_default_size (GTK_WINDOW (dialog),
                                     height * 8 / 7, height);
-       gtk_window_present (GTK_WINDOW (dialog->addto_dialog));
+       gtk_window_present (GTK_WINDOW (dialog));
 }
diff --git a/gnome-panel/panel-addto.h b/gnome-panel/panel-addto.h
index 4fe7863..6b4d406 100644
--- a/gnome-panel/panel-addto.h
+++ b/gnome-panel/panel-addto.h
@@ -23,10 +23,14 @@
 #ifndef __PANEL_ADDTO_H__
 #define __PANEL_ADDTO_H__
 
+#include <gtk/gtk.h>
+
 G_BEGIN_DECLS
 
-void panel_addto_present                    (GtkMenuItem *item,
-                                            PanelWidget *panel_widget);
+#define PANEL_TYPE_ADDTO_DIALOG panel_addto_dialog_get_type()
+G_DECLARE_FINAL_TYPE (PanelAddtoDialog, panel_addto_dialog, PANEL, ADDTO_DIALOG, GtkWindow);
+
+void panel_addto_present (GtkMenuItem *item, PanelWidget *panel_widget);
 
 G_END_DECLS
 
diff --git a/gnome-panel/panel.gresource.xml b/gnome-panel/panel.gresource.xml
index 7124d59..77da2de 100644
--- a/gnome-panel/panel.gresource.xml
+++ b/gnome-panel/panel.gresource.xml
@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <gresources>
   <gresource prefix="/org/gnome/panel">
+    <file compressed="true">panel-add-to-dialog.ui</file>
     <file compressed="true">panel-properties-dialog.ui</file>
     <file compressed="true">panel-run-dialog.ui</file>
     <file>wanda_no_sea.png</file>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]