[gtk+] places sidebar: Fix rows getting 'lost' when dnd fails
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+] places sidebar: Fix rows getting 'lost' when dnd fails
- Date: Wed, 8 Jul 2015 10:10:08 +0000 (UTC)
commit 8e53a011885adc749dc67e3553f21f9fbe4404e3
Author: Matthias Clasen <mclasen redhat com>
Date: Tue Jul 7 23:16:09 2015 -0400
places sidebar: Fix rows getting 'lost' when dnd fails
There was some code that lead to the places sidebar loosing track
of the row being dragged if a motion event came in between letting
go of the button and the drag snap-back animation ending. This would
cause us to not show the row again, giving the appearance that it
was 'lost'.
https://bugzilla.gnome.org/show_bug.cgi?id=751448
gtk/gtkplacessidebar.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
---
diff --git a/gtk/gtkplacessidebar.c b/gtk/gtkplacessidebar.c
index a591ea5..322b7f1 100644
--- a/gtk/gtkplacessidebar.c
+++ b/gtk/gtkplacessidebar.c
@@ -1456,11 +1456,7 @@ on_motion_notify_event (GtkWidget *widget,
return FALSE;
if (!(event->state & GDK_BUTTON1_MASK))
- {
- sidebar->drag_row = NULL;
-
- return FALSE;
- }
+ return FALSE;
if (gtk_drag_check_threshold (widget,
sidebar->drag_root_x, sidebar->drag_root_y,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]