[grilo-plugins] bookmarks: Notify about a removal if there was no error
- From: Bastien Nocera <hadess src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [grilo-plugins] bookmarks: Notify about a removal if there was no error
- Date: Tue, 7 Jul 2015 14:32:34 +0000 (UTC)
commit b1813db3a0d6e6011e2c1bd10e4807520fb55579
Author: Iain Lane <iain orangesquash org uk>
Date: Tue Jul 7 13:06:46 2015 +0100
bookmarks: Notify about a removal if there was no error
We were incorrectly checking that there *was* an error when deciding
whether to notify of removals. This led to missing notifications for
successful removals.
https://bugzilla.gnome.org/show_bug.cgi?id=752066
src/bookmarks/grl-bookmarks.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/bookmarks/grl-bookmarks.c b/src/bookmarks/grl-bookmarks.c
index c7f0109..2fb75b0 100644
--- a/src/bookmarks/grl-bookmarks.c
+++ b/src/bookmarks/grl-bookmarks.c
@@ -631,7 +631,7 @@ remove_bookmark (GrlBookmarksSource *bookmarks_source,
g_object_unref (resource);
- if (*error != NULL && bookmarks_source->priv->notify_changes) {
+ if (*error == NULL && bookmarks_source->priv->notify_changes) {
/* We can improve accuracy computing the parent container of removed
element */
grl_source_notify_change (GRL_SOURCE (bookmarks_source),
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]