[banshee/stable-2.6] NowPlaying: add workaround for crash in the Mac platform



commit 63923eea7732f7ceb25782b79ec1a801bb5a8ce4
Author: Andrés G. Aragoneses <knocte gmail com>
Date:   Fri Jul 3 00:04:12 2015 +0200

    NowPlaying: add workaround for crash in the Mac platform
    
    This patch was being pulled in manually in bockbuild[1].
    
    Details of the problem are here[2] (and some discussion about
    the same problem with the master branch, here[3]).
    
    It's better to bring it here officially than having a custom
    bockbuild patch, because our docs for building banshee don't
    rely on the banshee repo being built by bockbuild itself [4].
    
    [1] https://github.com/BansheeMediaPlayer/bockbuild/commit/f2da0b3c20e1eda022ed80a0a21ecc6a085c22f0
    [2] https://github.com/Dynalon/bockbuild/issues/1
    [3] https://bugzilla.gnome.org/show_bug.cgi?id=750100
    [4] http://banshee.fm/download/development/

 .../Banshee.NowPlaying/NowPlayingInterface.cs      |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)
---
diff --git a/src/Extensions/Banshee.NowPlaying/Banshee.NowPlaying/NowPlayingInterface.cs 
b/src/Extensions/Banshee.NowPlaying/Banshee.NowPlaying/NowPlayingInterface.cs
index be8a5c2..1904888 100644
--- a/src/Extensions/Banshee.NowPlaying/Banshee.NowPlaying/NowPlayingInterface.cs
+++ b/src/Extensions/Banshee.NowPlaying/Banshee.NowPlaying/NowPlayingInterface.cs
@@ -31,6 +31,8 @@ using System;
 using Mono.Unix;
 using Gtk;
 
+using Hyena;
+
 using Banshee.Gui;
 using Banshee.PlatformServices;
 using Banshee.ServiceStack;
@@ -99,7 +101,11 @@ namespace Banshee.NowPlaying
         {
             if (Contents.Parent != frame) {
                 Contents.Reparent (frame);
-                Contents.Show ();
+
+                // workaround for crash in Mac, see https://bugzilla.gnome.org/show_bug.cgi?id=750100#c6
+                if (!PlatformDetection.IsMac) {
+                    Contents.Show ();
+                }
             }
         }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]