[network-manager-applet/nma-1-0] applet/editor: no longer add 'serial' setting
- From: Lubomir Rintel <lkundrak src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [network-manager-applet/nma-1-0] applet/editor: no longer add 'serial' setting
- Date: Thu, 2 Jul 2015 08:05:50 +0000 (UTC)
commit 3d509a2bad4e0f81fce9c083650adeb69e37b4d0
Author: Dan Williams <dcbw redhat com>
Date: Wed Jul 1 16:06:52 2015 -0500
applet/editor: no longer add 'serial' setting
It's not used by NM/MM at all right now (and only relevant to things
that actually use plain old serial ports, like RS232 and some embedded
modems) so don't bother adding it.
(cherry picked from commit 604d7db2ca49a44fb095c787793ba3afcb50fdd9)
src/connection-editor/page-mobile.c | 17 -----------------
src/mobile-helpers.c | 10 ----------
2 files changed, 0 insertions(+), 27 deletions(-)
---
diff --git a/src/connection-editor/page-mobile.c b/src/connection-editor/page-mobile.c
index 7da1367..ef24184 100644
--- a/src/connection-editor/page-mobile.c
+++ b/src/connection-editor/page-mobile.c
@@ -436,22 +436,6 @@ ce_page_mobile_class_init (CEPageMobileClass *mobile_class)
object_class->dispose = dispose;
}
-static void
-add_default_serial_setting (NMConnection *connection)
-{
- NMSettingSerial *s_serial;
-
- s_serial = NM_SETTING_SERIAL (nm_setting_serial_new ());
- g_object_set (s_serial,
- NM_SETTING_SERIAL_BAUD, 115200,
- NM_SETTING_SERIAL_BITS, 8,
- NM_SETTING_SERIAL_PARITY, 'n',
- NM_SETTING_SERIAL_STOPBITS, 1,
- NULL);
-
- nm_connection_add_setting (connection, NM_SETTING (s_serial));
-}
-
typedef struct {
NMRemoteSettings *settings;
PageNewConnectionResultFunc result_func;
@@ -507,7 +491,6 @@ new_connection_mobile_wizard_done (NMAMobileWizard *wizard,
g_free (detail);
nm_connection_add_setting (connection, type_setting);
- add_default_serial_setting (connection);
nm_connection_add_setting (connection, nm_setting_ppp_new ());
}
diff --git a/src/mobile-helpers.c b/src/mobile-helpers.c
index f07523d..a2539d3 100644
--- a/src/mobile-helpers.c
+++ b/src/mobile-helpers.c
@@ -194,16 +194,6 @@ mobile_wizard_done (NMAMobileWizard *wizard,
} else
g_assert_not_reached ();
- /* Serial setting */
- setting = nm_setting_serial_new ();
- g_object_set (setting,
- NM_SETTING_SERIAL_BAUD, 115200,
- NM_SETTING_SERIAL_BITS, 8,
- NM_SETTING_SERIAL_PARITY, 'n',
- NM_SETTING_SERIAL_STOPBITS, 1,
- NULL);
- nm_connection_add_setting (connection, setting);
-
nm_connection_add_setting (connection, nm_setting_ppp_new ());
setting = nm_setting_connection_new ();
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]