[gnome-boxes/wip/automated-tests: 7/29] app-window: Explicitly unbind from Machine.status
- From: Zeeshan Ali Khattak <zeeshanak src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-boxes/wip/automated-tests: 7/29] app-window: Explicitly unbind from Machine.status
- Date: Sat, 31 Jan 2015 10:42:45 +0000 (UTC)
commit 4de0330590eb3c317816e1d691edcee4dcd8adaf
Author: Zeeshan Ali (Khattak) <zeeshanak gnome org>
Date: Fri Jan 30 16:31:08 2015 +0000
app-window: Explicitly unbind from Machine.status
Although removing our only reference to the binding should take care of
destroying the binding, it doesn't seem to currently be happening. This
somehow leads to memory corruptions 'open_three_new_windows' test
scenario.
Lets explicitly unbind, at least until we figure out and get the actual
issue fixed. Likely a Vala bug.
src/app-window.vala | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
---
diff --git a/src/app-window.vala b/src/app-window.vala
index ccfa4c7..dd10ebf 100644
--- a/src/app-window.vala
+++ b/src/app-window.vala
@@ -183,7 +183,10 @@ private class Boxes.AppWindow: Gtk.ApplicationWindow, Boxes.UI {
fullscreened = false;
view.visible = true;
- status_bind = null;
+ if (status_bind != null) {
+ status_bind.unbind (); // FIXME: We shouldn't neeed to explicitly unbind (Vala bug?)
+ status_bind = null;
+ }
topbar.status = _("Boxes");
if (current_item is Machine) {
var machine = current_item as Machine;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]