[gvfs] mtp: fix query_fs_info crash when file not found



commit dc8db939d67d464b5721ed34f505b0a96a2e8802
Author: Ondrej Holy <oholy redhat com>
Date:   Mon Jan 26 14:38:20 2015 +0100

    mtp: fix query_fs_info crash when file not found
    
    The function isn't returned after g_vfs_job_failed_literal, therefore
    g_vfs_job_succeeded is executed and it fails on assert.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=743580

 daemon/gvfsbackendmtp.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
---
diff --git a/daemon/gvfsbackendmtp.c b/daemon/gvfsbackendmtp.c
index 1e836a8..0366116 100644
--- a/daemon/gvfsbackendmtp.c
+++ b/daemon/gvfsbackendmtp.c
@@ -1455,6 +1455,7 @@ do_query_fs_info (GVfsBackend *backend,
       g_vfs_job_failed_literal (G_VFS_JOB (job),
                                 G_IO_ERROR, G_IO_ERROR_NOT_FOUND,
                                 _("File not found"));
+      goto exit;
     }
 
     LIBMTP_devicestorage_t *storage;
@@ -1467,6 +1468,7 @@ do_query_fs_info (GVfsBackend *backend,
 
   g_vfs_job_succeeded (G_VFS_JOB (job));
 
+ exit:
   g_strfreev (elements);
   g_mutex_unlock (&G_VFS_BACKEND_MTP (backend)->mutex);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]