[ekiga] BankImpl: Removed wrong API comment.
- From: Damien Sandras <dsandras src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [ekiga] BankImpl: Removed wrong API comment.
- Date: Sat, 24 Jan 2015 12:52:31 +0000 (UTC)
commit df9802c83a68896089da0970aa2443210d383997
Author: Damien Sandras <dsandras seconix com>
Date: Sat Jan 24 13:43:09 2015 +0100
BankImpl: Removed wrong API comment.
Any deleted BankImpl is automatically removed from the AccountCore.
This is not true anymore, and it is probably bad practice in this case.
We are using shared_ptr's, which means that the underlying object will
be deleted only when there are no more references to that object (if by
miracle, there are no cyclic references).
If we wait for the object to be deleted to remove it from the
AccountCore, it will never be removed as the AccountCore is a list (and
not a RefLister?) of shared_ptr's.
We need to work the other way around : each object using a Bank/BankImpl
needs to be destroyed and stop using it before the object is actually
automatically destroyed.
lib/engine/account/bank-impl.h | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
---
diff --git a/lib/engine/account/bank-impl.h b/lib/engine/account/bank-impl.h
index 5e10594..21f8dd9 100644
--- a/lib/engine/account/bank-impl.h
+++ b/lib/engine/account/bank-impl.h
@@ -54,9 +54,6 @@ namespace Ekiga
* bank: it will take care of implementing the external api, you
* just have to decide when to add and remove accounts.
*
- * Any deleted BankImpl is automatically removed from the AccountCore.
- * The implementor should not have to take care about that.
- *
* You can remove a Account from an Ekiga::BankImpl in two ways:
* - either by calling the remove_account method,
* - or by emission of the account's removed signal.
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]