[gnome-logs] Remove some debugging messages
- From: David King <davidk src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-logs] Remove some debugging messages
- Date: Thu, 22 Jan 2015 11:09:57 +0000 (UTC)
commit 39d5fac8920ccde98f7af2928f5809a8944d5641
Author: David King <davidk gnome org>
Date: Thu Jan 22 11:07:21 2015 +0000
Remove some debugging messages
Avoid making a comparison that is always true. To be effective, the
check for the number of results would have to know the requested number
of results, so in future this could be reported with a GError.
Found with Coverity (CID 86592).
src/gl-eventviewlist.c | 32 --------------------------------
1 files changed, 0 insertions(+), 32 deletions(-)
---
diff --git a/src/gl-eventviewlist.c b/src/gl-eventviewlist.c
index 6dabc33..8d1f392 100644
--- a/src/gl-eventviewlist.c
+++ b/src/gl-eventviewlist.c
@@ -371,7 +371,6 @@ query_devices_ready (GObject *source_object,
GlJournal *journal;
GError *error = NULL;
GList *l;
- gsize n_results;
view = GL_EVENT_VIEW_LIST (user_data);
priv = gl_event_view_list_get_instance_private (view);
@@ -385,13 +384,6 @@ query_devices_ready (GObject *source_object,
g_error_free (error);
}
- n_results = g_list_length (priv->results);
-
- if ((n_results != -1) && (n_results != N_RESULTS))
- {
- g_debug ("Number of results different than requested");
- }
-
priv->pending_results = g_queue_new ();
for (l = priv->results; l != NULL; l = g_list_next (l))
@@ -481,7 +473,6 @@ query_security_ready (GObject *source_object,
GlJournal *journal;
GError *error = NULL;
GList *l;
- guint n_results;
view = GL_EVENT_VIEW_LIST (user_data);
priv = gl_event_view_list_get_instance_private (view);
@@ -495,13 +486,6 @@ query_security_ready (GObject *source_object,
g_error_free (error);
}
- n_results = g_list_length (priv->results);
-
- if ((n_results != -1) && (n_results != N_RESULTS))
- {
- g_debug ("Number of results different than requested");
- }
-
priv->pending_results = g_queue_new ();
for (l = priv->results; l != NULL; l = g_list_next (l))
@@ -586,7 +570,6 @@ query_simple_ready (GObject *source_object,
GlJournal *journal;
GError *error = NULL;
GList *l;
- gsize n_results;
view = GL_EVENT_VIEW_LIST (user_data);
priv = gl_event_view_list_get_instance_private (view);
@@ -600,13 +583,6 @@ query_simple_ready (GObject *source_object,
g_error_free (error);
}
- n_results = g_list_length (priv->results);
-
- if ((n_results != -1) && (n_results != N_RESULTS))
- {
- g_debug ("Number of results different than requested");
- }
-
priv->pending_results = g_queue_new ();
for (l = priv->results; l != NULL; l = g_list_next (l))
@@ -689,7 +665,6 @@ query_cmdline_ready (GObject *source_object,
GlJournal *journal;
GError *error = NULL;
GList *l;
- gsize n_results;
view = GL_EVENT_VIEW_LIST (user_data);
priv = gl_event_view_list_get_instance_private (view);
@@ -703,13 +678,6 @@ query_cmdline_ready (GObject *source_object,
g_error_free (error);
}
- n_results = g_list_length (priv->results);
-
- if ((n_results != -1) && (n_results != N_RESULTS))
- {
- g_debug ("Number of results different than requested");
- }
-
priv->pending_results = g_queue_new ();
for (l = priv->results; l != NULL; l = g_list_next (l))
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]