[gimp] Bug 736411 - Ruler updates cause slowdown when painting

[Michael Natterer <mitch src gnome org>]

commit 20863440fbe754c34059ca04a042bd927fbb9d6b
Author: Massimo Valentini <mvalentini src gnome org>
Date:   Wed Dec 3 07:44:45 2014 +0100

    Bug 736411 - Ruler updates cause slowdown when painting
    
    Reuse the cairo_t from expose() in gimp_ruler_draw_pos() instead of
    creating a new one.

 libgimpwidgets/gimpruler.c |   40 +++++++++++++++++++++++++---------------
 1 files changed, 25 insertions(+), 15 deletions(-)
---
diff --git a/libgimpwidgets/gimpruler.c b/libgimpwidgets/gimpruler.c
index d337b81..eacbb51 100644
--- a/libgimpwidgets/gimpruler.c
+++ b/libgimpwidgets/gimpruler.c
@@ -119,7 +119,8 @@ static gboolean      gimp_ruler_expose        (GtkWidget      *widget,
                                                GdkEventExpose *event);
 
 static void          gimp_ruler_draw_ticks    (GimpRuler      *ruler);
-static void          gimp_ruler_draw_pos      (GimpRuler      *ruler);
+static void          gimp_ruler_draw_pos      (GimpRuler      *ruler,
+                                               cairo_t        *cr);
 static void          gimp_ruler_make_pixmap   (GimpRuler      *ruler);
 
 static PangoLayout * gimp_ruler_get_layout    (GtkWidget      *widget,
@@ -616,7 +617,7 @@ gimp_ruler_set_position (GimpRuler *ruler,
       priv->position = position;
       g_object_notify (G_OBJECT (ruler), "position");
 
-      gimp_ruler_draw_pos (ruler);
+      gimp_ruler_draw_pos (ruler, NULL);
     }
 }
 
@@ -894,7 +895,7 @@ gimp_ruler_expose (GtkWidget      *widget,
       cairo_set_source_surface (cr, priv->backing_store, 0, 0);
       cairo_paint (cr);
 
-      gimp_ruler_draw_pos (ruler);
+      gimp_ruler_draw_pos (ruler, cr);
 
       cairo_destroy (cr);
     }
@@ -1141,7 +1142,8 @@ out:
 }
 
 static void
-gimp_ruler_draw_pos (GimpRuler *ruler)
+gimp_ruler_draw_pos (GimpRuler *ruler,
+                     cairo_t   *cr)
 {
   GtkWidget        *widget = GTK_WIDGET (ruler);
   GtkStyle         *style  = gtk_widget_get_style (widget);
@@ -1183,25 +1185,33 @@ gimp_ruler_draw_pos (GimpRuler *ruler)
 
   if ((bs_width > 0) && (bs_height > 0))
     {
-      cairo_t *cr = gdk_cairo_create (gtk_widget_get_window (widget));
       gdouble  lower;
       gdouble  upper;
       gdouble  position;
       gdouble  increment;
 
-      cairo_rectangle (cr,
-                       allocation.x, allocation.y,
-                       allocation.width, allocation.height);
-      cairo_clip (cr);
+      if (! cr)
+        {
+          cr = gdk_cairo_create (gtk_widget_get_window (widget));
 
-      cairo_translate (cr, allocation.x, allocation.y);
+          cairo_rectangle (cr,
+                           allocation.x, allocation.y,
+                           allocation.width, allocation.height);
+          cairo_clip (cr);
+
+          cairo_translate (cr, allocation.x, allocation.y);
 
-      /*  If a backing store exists, restore the ruler  */
-      if (priv->backing_store)
+          /*  If a backing store exists, restore the ruler  */
+          if (priv->backing_store)
+            {
+              cairo_set_source_surface (cr, priv->backing_store, 0, 0);
+              cairo_rectangle (cr, priv->xsrc, priv->ysrc, bs_width, bs_height);
+              cairo_fill (cr);
+            }
+        }
+      else
         {
-          cairo_set_source_surface (cr, priv->backing_store, 0, 0);
-          cairo_rectangle (cr, priv->xsrc, priv->ysrc, bs_width, bs_height);
-          cairo_fill (cr);
+          cairo_reference (cr);
         }
 
       position = gimp_ruler_get_position (ruler);