[jhbuild] resolver: warn on circular dependencies
- From: Ryan Lortie <desrt src gnome org>
- To: commits-list gnome org
- Cc: 
- Subject: [jhbuild] resolver: warn on circular dependencies
- Date: Tue,  6 Jan 2015 20:06:01 +0000 (UTC)
commit bfa36c2a300d90152e189e719ecc4140ea6ab579
Author: Ryan Lortie <desrt desrt ca>
Date:   Tue Dec 30 22:18:54 2014 -0500
    resolver: warn on circular dependencies
    
    Enable the warning for circular dependencies in module sets.
    
    This warning being disabled by default has almost certainly led to
    incorrect use of <suggests> in our modulesets.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=693290
 jhbuild/moduleset.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/jhbuild/moduleset.py b/jhbuild/moduleset.py
index 47cf130..695b3fa 100644
--- a/jhbuild/moduleset.py
+++ b/jhbuild/moduleset.py
@@ -107,7 +107,7 @@ class ModuleSet:
 
     def get_full_module_list(self, module_names='all', skip=[],
                                 include_suggests=True, include_afters=False,
-                                warn_about_circular_dependencies=False):
+                                warn_about_circular_dependencies=True):
 
         def dep_resolve(node, resolved, seen, after):
             ''' Recursive depth-first search of the dependency tree. Creates
[
Date Prev][
Date Next]   [
Thread Prev][
Thread Next]   
[
Thread Index]
[
Date Index]
[
Author Index]