[libsoup] tests: fix bug in checking for a bug in xmlrpc-test
- From: Dan Winship <danw src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [libsoup] tests: fix bug in checking for a bug in xmlrpc-test
- Date: Fri, 2 Jan 2015 14:05:39 +0000 (UTC)
commit a3d6fea00b9f27cd89495a6399e5fcc99e30af10
Author: Dan Winship <danw gnome org>
Date: Fri Jan 2 09:02:05 2015 -0500
tests: fix bug in checking for a bug in xmlrpc-test
When porting to gtestutils, the check for "PHP is buggy" in
xmlrpc-test got messed up so that it triggered even when PHP wasn't
buggy, causing the test to get labelled as "skipped".
Since the PHP bug in question (https://bugs.php.net/45996) was fixed
years ago anyway, just remove the workaround for it.
tests/xmlrpc-test.c | 16 +---------------
1 files changed, 1 insertions(+), 15 deletions(-)
---
diff --git a/tests/xmlrpc-test.c b/tests/xmlrpc-test.c
index f6b20b8..cf9cb91 100644
--- a/tests/xmlrpc-test.c
+++ b/tests/xmlrpc-test.c
@@ -327,13 +327,6 @@ static const char *const echo_strings[] = {
};
#define N_ECHO_STRINGS G_N_ELEMENTS (echo_strings)
-static const char *const echo_strings_broken[] = {
- "This is a test",
- " so is this",
- "and so is this",
- "amp; so is lt;thisgt;"
-};
-
static void
test_echo (void)
{
@@ -371,15 +364,8 @@ test_echo (void)
g_assert_cmpint (echoes->n_values, ==, N_ECHO_STRINGS);
- for (i = 0; i < echoes->n_values; i++) {
- if (!server_test && strcmp (echo_strings_broken[i], g_value_get_string (&echoes->values[i]))
== 0) {
- g_test_skip ("PHP bug");
- g_value_array_free (echoes);
- return;
- }
-
+ for (i = 0; i < echoes->n_values; i++)
g_assert_cmpstr (echo_strings[i], ==, g_value_get_string (&echoes->values[i]));
- }
g_value_array_free (echoes);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]