[evolution] HTML events callbacks are not called



commit 09124ab63d376bd97238bea92b42202c92df1872
Author: Tomas Popela <tpopela redhat com>
Date:   Fri Feb 27 08:55:41 2015 +0100

    HTML events callbacks are not called
    
    The problem is that if we call webkit_dom_event_target_add_event_listener
    on the element and unref it afterwards (even when we get that element
    from WebKitDOMNodeList) the callback won't be called at all.

 addressbook/gui/widgets/eab-contact-formatter.c |    1 -
 mail/e-mail-display.c                           |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)
---
diff --git a/addressbook/gui/widgets/eab-contact-formatter.c b/addressbook/gui/widgets/eab-contact-formatter.c
index 53e4f9e..8f32688 100644
--- a/addressbook/gui/widgets/eab-contact-formatter.c
+++ b/addressbook/gui/widgets/eab-contact-formatter.c
@@ -1440,7 +1440,6 @@ eab_contact_formatter_bind_dom (WebKitDOMDocument *document)
                webkit_dom_event_target_add_event_listener (
                        WEBKIT_DOM_EVENT_TARGET (node), "click",
                        G_CALLBACK (collapse_contacts_list), FALSE, document);
-               g_object_unref (node);
        }
 
        g_object_unref (nodes);
diff --git a/mail/e-mail-display.c b/mail/e-mail-display.c
index 880fe67..607278a 100644
--- a/mail/e-mail-display.c
+++ b/mail/e-mail-display.c
@@ -977,7 +977,6 @@ setup_image_click_event_listeners_on_document (WebKitDOMDocument *document,
                        WEBKIT_DOM_EVENT_TARGET (button), "click",
                        G_CALLBACK (toggle_address_visibility), FALSE,
                        NULL);
-               g_object_unref (button);
        }
        g_object_unref (list);
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]