[gnome-shell: 112/136] messageTray: Remove summary notification
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell: 112/136] messageTray: Remove summary notification
- Date: Fri, 20 Feb 2015 16:45:33 +0000 (UTC)
commit f2d0fcabd1daa9209b5300efb934644903aec778
Author: Florian Müllner <fmuellner gnome org>
Date: Sat Feb 14 03:19:49 2015 +0100
messageTray: Remove summary notification
Using a "There are too many notifications" notification is a bit odd,
and we will address the issue differently soon. So rather than update
the notification to do something else than opening the mostly empty and
useless tray when clicked, remove it altogether.
https://bugzilla.gnome.org/show_bug.cgi?id=744850
js/ui/messageTray.js | 18 ++----------------
1 files changed, 2 insertions(+), 16 deletions(-)
---
diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index 4bf2580..2e879fd 100644
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -2036,22 +2036,8 @@ const MessageTray = new Lang.Class({
if (shouldShowNotification && nextNotification) {
let limited = this._busy || Main.layoutManager.bottomMonitor.inFullscreen;
let showNextNotification = (!limited || nextNotification.forFeedback ||
nextNotification.urgency == Urgency.CRITICAL);
- if (showNextNotification) {
- let len = this._notificationQueue.length;
- if (len > 1) {
- this._notificationQueue.length = 0;
- let source = new SystemNotificationSource();
- this.add(source);
- let notification = new Notification(source, ngettext("%d new message", "%d new
messages", len).format(len));
- notification.setTransient(true);
- notification.connect('activated', Lang.bind(this, function() {
- this.openTray();
- }));
- source.notify(notification);
- } else {
- this._showNotification();
- }
- }
+ if (showNextNotification)
+ this._showNotification();
}
} else if (this._notificationState == State.SHOWN) {
let expired = (this._userActiveWhileNotificationShown &&
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]