[gnome-shell/wip/fmuellner/notification-redux+sass: 137/145] messageTray: Limit number of buttons in banners



commit 5f071aa336a88f47980db1a6fa5ce44d35eb3865
Author: Florian Müllner <fmuellner gnome org>
Date:   Tue Feb 17 03:53:00 2015 +0100

    messageTray: Limit number of buttons in banners
    
    The design states that notifications should have a maximum of three
    buttons, so enforce this.

 js/ui/messageTray.js |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
---
diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index 234a8d9..372e779 100644
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -30,6 +30,7 @@ const LONGER_HIDE_TIMEOUT = 0.6;
 
 const MAX_NOTIFICATIONS_IN_QUEUE = 3;
 const MAX_NOTIFICATIONS_PER_SOURCE = 3;
+const MAX_NOTIFICATION_BUTTONS = 3;
 
 // We delay hiding of the tray if the mouse is within MOUSE_LEFT_ACTOR_THRESHOLD
 // range from the point where it left the tray.
@@ -1169,6 +1170,9 @@ const NotificationBanner = new Lang.Class({
             global.focus_manager.add_group(this._buttonBox);
         }
 
+        if (this._buttonBox.get_n_children() >= MAX_NOTIFICATION_BUTTONS)
+            return null;
+
         this._buttonBox.add(button);
         button.connect('clicked', Lang.bind(this, function() {
             callback();


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]