[gnome-shell/wip/sass] status: Stop using .panel-status-button



commit 85ad4e35dd6d40d2ebdd5e05e3ce83d5cc9fb550
Author: Florian Müllner <fmuellner gnome org>
Date:   Wed Feb 18 00:01:09 2015 +0100

    status: Stop using .panel-status-button
    
    This used to be the style-class for status icons (i.e. icon-only
    top bar items). It got unused a while ago when the class used
    by status icons stopped using it - except for the keyboard indicator,
    which set the class manually to appear as status icon despite not
    being a real icon.
    Now that the button highlight is provided by the .panel-button class
    on a parent, the obsolete class results in a double border on the
    keyboard indicator when active - just drop it from there as well
    to fix.

 data/theme/_common.scss                  |    8 --------
 data/theme/gnome-shell-high-contrast.css |    6 ++----
 data/theme/gnome-shell.css               |    3 ---
 js/ui/status/keyboard.js                 |    1 -
 4 files changed, 2 insertions(+), 16 deletions(-)
---
diff --git a/data/theme/_common.scss b/data/theme/_common.scss
index 701a5cf..e1542f2 100644
--- a/data/theme/_common.scss
+++ b/data/theme/_common.scss
@@ -687,14 +687,6 @@ StScrollBar {
     }
   }
   
-  .panel-status-button {
-  
-    &:active, &:overview, &:focus, &:checked {
-      border-color: lighten($selected_bg_color,5%);
-      border-bottom-width: 2px;
-    }
-  }
-  
   .panel-status-indicators-box,
   .panel-status-menu-box {
     spacing: 2px;
diff --git a/data/theme/gnome-shell-high-contrast.css b/data/theme/gnome-shell-high-contrast.css
index 8e72770..7cee0d4 100644
--- a/data/theme/gnome-shell-high-contrast.css
+++ b/data/theme/gnome-shell-high-contrast.css
@@ -555,7 +555,8 @@ StScrollBar {
       -panel-corner-background-color: transparent;
       -panel-corner-border-color: transparent; }
   #panel .panel-button {
-    padding: 0px 12px;
+    -natural-hpadding: 12px;
+    -minimum-hpadding: 6px;
     font-weight: bold;
     color: #ccc;
     transition-duration: 100ms; }
@@ -579,9 +580,6 @@ StScrollBar {
       color: white; }
       .unlock-screen #panel .panel-button:focus, .unlock-screen #panel .panel-button:hover, .unlock-screen 
#panel .panel-button:active, .login-screen #panel .panel-button:focus, .login-screen #panel 
.panel-button:hover, .login-screen #panel .panel-button:active, .lock-screen #panel .panel-button:focus, 
.lock-screen #panel .panel-button:hover, .lock-screen #panel .panel-button:active {
         color: white; }
-  #panel .panel-status-button:active, #panel .panel-status-button:overview, #panel 
.panel-status-button:focus, #panel .panel-status-button:checked {
-    border-color: #256ab1;
-    border-bottom-width: 2px; }
   #panel .panel-status-indicators-box,
   #panel .panel-status-menu-box {
     spacing: 2px; }
diff --git a/data/theme/gnome-shell.css b/data/theme/gnome-shell.css
index 6e44384..1e08909 100644
--- a/data/theme/gnome-shell.css
+++ b/data/theme/gnome-shell.css
@@ -580,9 +580,6 @@ StScrollBar {
       color: white; }
       .unlock-screen #panel .panel-button:focus, .unlock-screen #panel .panel-button:hover, .unlock-screen 
#panel .panel-button:active, .login-screen #panel .panel-button:focus, .login-screen #panel 
.panel-button:hover, .login-screen #panel .panel-button:active, .lock-screen #panel .panel-button:focus, 
.lock-screen #panel .panel-button:hover, .lock-screen #panel .panel-button:active {
         color: white; }
-  #panel .panel-status-button:active, #panel .panel-status-button:overview, #panel 
.panel-status-button:focus, #panel .panel-status-button:checked {
-    border-color: #256ab1;
-    border-bottom-width: 2px; }
   #panel .panel-status-indicators-box,
   #panel .panel-status-menu-box {
     spacing: 2px; }
diff --git a/js/ui/status/keyboard.js b/js/ui/status/keyboard.js
index 3595a39..e3938d5 100644
--- a/js/ui/status/keyboard.js
+++ b/js/ui/status/keyboard.js
@@ -589,7 +589,6 @@ const InputSourceIndicator = new Lang.Class({
         this._hbox.add_child(PopupMenu.arrowIcon(St.Side.BOTTOM));
 
         this.actor.add_child(this._hbox);
-        this.actor.add_style_class_name('panel-status-button');
 
         this._propSeparator = new PopupMenu.PopupSeparatorMenuItem();
         this.menu.addMenuItem(this._propSeparator);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]