[gdm/wip/xserver-in-session: 11/54] xdmcp-chooser-display: remove dubious looking finish implementation



commit 324ef22c5debf29ee1bcabfd27a2e3323d64b56a
Author: Ray Strode <rstrode redhat com>
Date:   Mon Jan 19 09:09:49 2015 -0500

    xdmcp-chooser-display: remove dubious looking finish implementation
    
    This commit drops the finish implementation from the
    xdmcp-chooser-display subclass.  It's mostly just chaining up, but it
    also calls "unmanage" which is strange and probably wrong.

 daemon/gdm-xdmcp-chooser-display.c |   14 --------------
 1 files changed, 0 insertions(+), 14 deletions(-)
---
diff --git a/daemon/gdm-xdmcp-chooser-display.c b/daemon/gdm-xdmcp-chooser-display.c
index 72e3d07..371c2b0 100644
--- a/daemon/gdm-xdmcp-chooser-display.c
+++ b/daemon/gdm-xdmcp-chooser-display.c
@@ -52,7 +52,6 @@ static guint signals [LAST_SIGNAL] = { 0, };
 static void     gdm_xdmcp_chooser_display_class_init    (GdmXdmcpChooserDisplayClass *klass);
 static void     gdm_xdmcp_chooser_display_init          (GdmXdmcpChooserDisplay      *xdmcp_chooser_display);
 static gboolean gdm_xdmcp_chooser_display_prepare       (GdmDisplay *display);
-static gboolean gdm_xdmcp_chooser_display_finish        (GdmDisplay *display);
 
 G_DEFINE_TYPE (GdmXdmcpChooserDisplay, gdm_xdmcp_chooser_display, GDM_TYPE_XDMCP_DISPLAY)
 
@@ -72,7 +71,6 @@ gdm_xdmcp_chooser_display_class_init (GdmXdmcpChooserDisplayClass *klass)
         GdmDisplayClass *display_class = GDM_DISPLAY_CLASS (klass);
 
         display_class->prepare = gdm_xdmcp_chooser_display_prepare;
-        display_class->finish = gdm_xdmcp_chooser_display_finish;
 
         signals [HOSTNAME_SELECTED] =
                 g_signal_new ("hostname-selected",
@@ -108,18 +106,6 @@ gdm_xdmcp_chooser_display_prepare (GdmDisplay *display)
         return TRUE;
 }
 
-static gboolean
-gdm_xdmcp_chooser_display_finish (GdmDisplay *display)
-{
-        g_return_val_if_fail (GDM_IS_DISPLAY (display), FALSE);
-
-        GDM_DISPLAY_CLASS (gdm_xdmcp_chooser_display_parent_class)->finish (display);
-
-        gdm_display_unmanage (display);
-
-        return TRUE;
-}
-
 GdmDisplay *
 gdm_xdmcp_chooser_display_new (const char              *hostname,
                                int                      number,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]