[gnome-shell] panelMenu: Consider vertical margins when computing max-height
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] panelMenu: Consider vertical margins when computing max-height
- Date: Sun, 15 Feb 2015 16:54:42 +0000 (UTC)
commit 7bb7734869c097b2089c831714d1c65884481d19
Author: Florian Müllner <fmuellner gnome org>
Date: Fri Feb 13 20:52:11 2015 +0100
panelMenu: Consider vertical margins when computing max-height
When opening a panel menu, we set it's max-height to the available
work-area height to keep menus with scrollable content from growing
outside the monitor. However a menu that extends all the way down
to the bottom edge does not look great either, so also take margins
into account here.
https://bugzilla.gnome.org/show_bug.cgi?id=744498
data/theme/gnome-shell.css | 1 +
js/ui/panelMenu.js | 3 ++-
2 files changed, 3 insertions(+), 1 deletions(-)
---
diff --git a/data/theme/gnome-shell.css b/data/theme/gnome-shell.css
index 09b692a..072f18b 100644
--- a/data/theme/gnome-shell.css
+++ b/data/theme/gnome-shell.css
@@ -715,6 +715,7 @@ StScrollBar StButton#vhandle:active {
.panel-menu {
-boxpointer-gap: 4px;
+ margin-bottom: 1.75em;
}
.panel-status-indicators-box,
diff --git a/js/ui/panelMenu.js b/js/ui/panelMenu.js
index 29acd29..092ca23 100644
--- a/js/ui/panelMenu.js
+++ b/js/ui/panelMenu.js
@@ -173,7 +173,8 @@ const Button = new Lang.Class({
// menu is higher then the screen; it's useful if part of the menu is
// scrollable so the minimum height is smaller than the natural height
let workArea = Main.layoutManager.getWorkAreaForMonitor(Main.layoutManager.primaryIndex);
- this.menu.actor.style = ('max-height: ' + Math.round(workArea.height) + 'px;');
+ let verticalMargins = this.menu.actor.margin_top + this.menu.actor.margin_bottom;
+ this.menu.actor.style = ('max-height: ' + Math.round(workArea.height - verticalMargins) + 'px;');
},
destroy: function() {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]