[gnome-software/wip/kalev/codecs: 1/12] Don't include gs-cleanup.h from other .h files



commit 669391e835e627800f94971bba1d4626a7a5472f
Author: Kalev Lember <kalevlember gmail com>
Date:   Tue Feb 3 12:55:31 2015 +0100

    Don't include gs-cleanup.h from other .h files
    
    Instead, include gs-cleanup.h directly in the .c files that use the
    cleanup functions.

 src/gs-app-addon-row.c                        |    1 +
 src/gs-history-dialog.c                       |    1 +
 src/gs-plugin.h                               |    1 -
 src/plugins/gs-plugin-appstream.c             |    1 +
 src/plugins/gs-plugin-epiphany.c              |    1 +
 src/plugins/gs-plugin-fedora-tagger-ratings.c |    1 +
 src/plugins/gs-plugin-fedora-tagger-usage.c   |    1 +
 src/plugins/gs-plugin-hardcoded-categories.c  |    1 +
 src/plugins/gs-plugin-hardcoded-featured.c    |    1 +
 src/plugins/gs-plugin-icons.c                 |    1 +
 src/plugins/gs-plugin-local-ratings.c         |    1 +
 src/plugins/gs-plugin-menu-spec-categories.c  |    1 +
 src/plugins/gs-plugin-menu-spec-refine.c      |    1 +
 src/plugins/gs-plugin-moduleset.c             |    1 +
 src/plugins/gs-plugin-packagekit-history.c    |    1 +
 src/plugins/gs-plugin-packagekit-offline.c    |    1 +
 src/plugins/gs-plugin-packagekit-refine.c     |    1 +
 src/plugins/gs-plugin-packagekit-refresh.c    |    1 +
 src/plugins/gs-plugin-packagekit.c            |    1 +
 src/plugins/gs-plugin-systemd-updates.c       |    1 +
 src/plugins/packagekit-common.c               |    2 ++
 21 files changed, 21 insertions(+), 1 deletions(-)
---
diff --git a/src/gs-app-addon-row.c b/src/gs-app-addon-row.c
index 6086fdd..ee5101f 100644
--- a/src/gs-app-addon-row.c
+++ b/src/gs-app-addon-row.c
@@ -26,6 +26,7 @@
 #include <gtk/gtk.h>
 
 #include "gs-app-addon-row.h"
+#include "gs-cleanup.h"
 #include "gs-utils.h"
 
 struct _GsAppAddonRowPrivate
diff --git a/src/gs-history-dialog.c b/src/gs-history-dialog.c
index 2ec2edf..e66c5ab 100644
--- a/src/gs-history-dialog.c
+++ b/src/gs-history-dialog.c
@@ -26,6 +26,7 @@
 #include <gtk/gtk.h>
 
 #include "gs-history-dialog.h"
+#include "gs-cleanup.h"
 #include "gs-utils.h"
 
 struct _GsHistoryDialogPrivate
diff --git a/src/gs-plugin.h b/src/gs-plugin.h
index 84ee6f4..5c9399e 100644
--- a/src/gs-plugin.h
+++ b/src/gs-plugin.h
@@ -29,7 +29,6 @@
 
 #include "gs-app.h"
 #include "gs-category.h"
-#include "gs-cleanup.h"
 #include "gs-profile.h"
 
 G_BEGIN_DECLS
diff --git a/src/plugins/gs-plugin-appstream.c b/src/plugins/gs-plugin-appstream.c
index 83d239a..547d13a 100644
--- a/src/plugins/gs-plugin-appstream.c
+++ b/src/plugins/gs-plugin-appstream.c
@@ -24,6 +24,7 @@
 #include <locale.h>
 #include <appstream-glib.h>
 
+#include "gs-cleanup.h"
 #include <gs-plugin.h>
 #include <gs-plugin-loader.h>
 
diff --git a/src/plugins/gs-plugin-epiphany.c b/src/plugins/gs-plugin-epiphany.c
index 0bce057..4f3ba99 100644
--- a/src/plugins/gs-plugin-epiphany.c
+++ b/src/plugins/gs-plugin-epiphany.c
@@ -27,6 +27,7 @@
 #include <glib/gi18n.h>
 #include <libsoup/soup.h>
 
+#include "gs-cleanup.h"
 #include <gs-plugin.h>
 #include <gs-utils.h>
 
diff --git a/src/plugins/gs-plugin-fedora-tagger-ratings.c b/src/plugins/gs-plugin-fedora-tagger-ratings.c
index 675148c..7d4b7e9 100644
--- a/src/plugins/gs-plugin-fedora-tagger-ratings.c
+++ b/src/plugins/gs-plugin-fedora-tagger-ratings.c
@@ -26,6 +26,7 @@
 #include <sqlite3.h>
 #include <stdlib.h>
 
+#include "gs-cleanup.h"
 #include <gs-plugin.h>
 #include <gs-utils.h>
 
diff --git a/src/plugins/gs-plugin-fedora-tagger-usage.c b/src/plugins/gs-plugin-fedora-tagger-usage.c
index f88635b..c042dc5 100644
--- a/src/plugins/gs-plugin-fedora-tagger-usage.c
+++ b/src/plugins/gs-plugin-fedora-tagger-usage.c
@@ -26,6 +26,7 @@
 #include <sqlite3.h>
 #include <stdlib.h>
 
+#include "gs-cleanup.h"
 #include <gs-plugin.h>
 #include <gs-utils.h>
 
diff --git a/src/plugins/gs-plugin-hardcoded-categories.c b/src/plugins/gs-plugin-hardcoded-categories.c
index b700af1..cdc6d6b 100644
--- a/src/plugins/gs-plugin-hardcoded-categories.c
+++ b/src/plugins/gs-plugin-hardcoded-categories.c
@@ -24,6 +24,7 @@
 
 #include <glib/gi18n.h>
 
+#include "gs-cleanup.h"
 #include <gs-plugin.h>
 #include <gs-category.h>
 
diff --git a/src/plugins/gs-plugin-hardcoded-featured.c b/src/plugins/gs-plugin-hardcoded-featured.c
index 71c55ad..7dff856 100644
--- a/src/plugins/gs-plugin-hardcoded-featured.c
+++ b/src/plugins/gs-plugin-hardcoded-featured.c
@@ -21,6 +21,7 @@
 
 #include <config.h>
 
+#include "gs-cleanup.h"
 #include <gs-plugin.h>
 
 /**
diff --git a/src/plugins/gs-plugin-icons.c b/src/plugins/gs-plugin-icons.c
index a32ed61..80f2118 100644
--- a/src/plugins/gs-plugin-icons.c
+++ b/src/plugins/gs-plugin-icons.c
@@ -27,6 +27,7 @@
 #include <glib/gi18n.h>
 #include <libsoup/soup.h>
 
+#include "gs-cleanup.h"
 #include <gs-plugin.h>
 #include <gs-utils.h>
 
diff --git a/src/plugins/gs-plugin-local-ratings.c b/src/plugins/gs-plugin-local-ratings.c
index bc74bd9..d82be80 100644
--- a/src/plugins/gs-plugin-local-ratings.c
+++ b/src/plugins/gs-plugin-local-ratings.c
@@ -24,6 +24,7 @@
 #include <sqlite3.h>
 #include <stdlib.h>
 
+#include "gs-cleanup.h"
 #include <gs-plugin.h>
 #include <gs-utils.h>
 
diff --git a/src/plugins/gs-plugin-menu-spec-categories.c b/src/plugins/gs-plugin-menu-spec-categories.c
index e0f47d5..a8240b9 100644
--- a/src/plugins/gs-plugin-menu-spec-categories.c
+++ b/src/plugins/gs-plugin-menu-spec-categories.c
@@ -24,6 +24,7 @@
 #include <gs-plugin.h>
 #include <glib/gi18n.h>
 
+#include "gs-cleanup.h"
 #include "menu-spec-common.h"
 
 /**
diff --git a/src/plugins/gs-plugin-menu-spec-refine.c b/src/plugins/gs-plugin-menu-spec-refine.c
index bfbce0f..d7c6521 100644
--- a/src/plugins/gs-plugin-menu-spec-refine.c
+++ b/src/plugins/gs-plugin-menu-spec-refine.c
@@ -24,6 +24,7 @@
 #include <gs-plugin.h>
 #include <glib/gi18n.h>
 
+#include "gs-cleanup.h"
 #include "menu-spec-common.h"
 
 /**
diff --git a/src/plugins/gs-plugin-moduleset.c b/src/plugins/gs-plugin-moduleset.c
index 4329d95..120601a 100644
--- a/src/plugins/gs-plugin-moduleset.c
+++ b/src/plugins/gs-plugin-moduleset.c
@@ -24,6 +24,7 @@
 
 #include <glib/gi18n.h>
 
+#include "gs-cleanup.h"
 #include <gs-plugin.h>
 #include <gs-category.h>
 
diff --git a/src/plugins/gs-plugin-packagekit-history.c b/src/plugins/gs-plugin-packagekit-history.c
index cfc29cc..caa8f18 100644
--- a/src/plugins/gs-plugin-packagekit-history.c
+++ b/src/plugins/gs-plugin-packagekit-history.c
@@ -24,6 +24,7 @@
 #define I_KNOW_THE_PACKAGEKIT_GLIB2_API_IS_SUBJECT_TO_CHANGE
 #include <packagekit-glib2/packagekit.h>
 
+#include "gs-cleanup.h"
 #include <gs-plugin.h>
 
 #define GS_PLUGIN_PACKAGEKIT_HISTORY_TIMEOUT   5000 /* ms */
diff --git a/src/plugins/gs-plugin-packagekit-offline.c b/src/plugins/gs-plugin-packagekit-offline.c
index 76ac944..70a8fba 100644
--- a/src/plugins/gs-plugin-packagekit-offline.c
+++ b/src/plugins/gs-plugin-packagekit-offline.c
@@ -21,6 +21,7 @@
 
 #include <config.h>
 
+#include "gs-cleanup.h"
 #include <gs-plugin.h>
 
 /**
diff --git a/src/plugins/gs-plugin-packagekit-refine.c b/src/plugins/gs-plugin-packagekit-refine.c
index ad9bdd5..c01e470 100644
--- a/src/plugins/gs-plugin-packagekit-refine.c
+++ b/src/plugins/gs-plugin-packagekit-refine.c
@@ -24,6 +24,7 @@
 #define I_KNOW_THE_PACKAGEKIT_GLIB2_API_IS_SUBJECT_TO_CHANGE
 #include <packagekit-glib2/packagekit.h>
 
+#include "gs-cleanup.h"
 #include <gs-plugin.h>
 #include <gs-utils.h>
 #include <glib/gi18n.h>
diff --git a/src/plugins/gs-plugin-packagekit-refresh.c b/src/plugins/gs-plugin-packagekit-refresh.c
index 9bfd454..d2a6ecc 100644
--- a/src/plugins/gs-plugin-packagekit-refresh.c
+++ b/src/plugins/gs-plugin-packagekit-refresh.c
@@ -25,6 +25,7 @@
 #include <packagekit-glib2/packagekit.h>
 #include <glib/gi18n.h>
 
+#include "gs-cleanup.h"
 #include <gs-plugin.h>
 
 #include "packagekit-common.h"
diff --git a/src/plugins/gs-plugin-packagekit.c b/src/plugins/gs-plugin-packagekit.c
index 5df18df..c4c81a3 100644
--- a/src/plugins/gs-plugin-packagekit.c
+++ b/src/plugins/gs-plugin-packagekit.c
@@ -25,6 +25,7 @@
 #include <packagekit-glib2/packagekit.h>
 #include <glib/gi18n.h>
 
+#include "gs-cleanup.h"
 #include <gs-plugin.h>
 
 #include "packagekit-common.h"
diff --git a/src/plugins/gs-plugin-systemd-updates.c b/src/plugins/gs-plugin-systemd-updates.c
index cdab5a8..449fe5b 100644
--- a/src/plugins/gs-plugin-systemd-updates.c
+++ b/src/plugins/gs-plugin-systemd-updates.c
@@ -25,6 +25,7 @@
 #define I_KNOW_THE_PACKAGEKIT_GLIB2_API_IS_SUBJECT_TO_CHANGE
 #include <packagekit-glib2/packagekit.h>
 
+#include "gs-cleanup.h"
 #include <gs-plugin.h>
 
 struct GsPluginPrivate {
diff --git a/src/plugins/packagekit-common.c b/src/plugins/packagekit-common.c
index 548d5ed..3e8b56a 100644
--- a/src/plugins/packagekit-common.c
+++ b/src/plugins/packagekit-common.c
@@ -23,6 +23,8 @@
 
 #define I_KNOW_THE_PACKAGEKIT_GLIB2_API_IS_SUBJECT_TO_CHANGE
 #include <packagekit-glib2/packagekit.h>
+
+#include "gs-cleanup.h"
 #include <gs-plugin.h>
 
 #include "packagekit-common.h"


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]