[gparted] Fix double quote error creating XFS file systems (#744108)
- From: Curtis Gedak <gedakc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gparted] Fix double quote error creating XFS file systems (#744108)
- Date: Sat, 7 Feb 2015 17:35:24 +0000 (UTC)
commit 70cc6187d510ce5c53349b8f02e7f495a12ce4a2
Author: Mike Fleetwood <mike fleetwood googlemail com>
Date: Fri Feb 6 19:27:48 2015 +0000
Fix double quote error creating XFS file systems (#744108)
Trying to create an XFS file system causes the following error and
the create new xfs file system step to never complete.
# ./gpartedbin
======================
libparted : 2.4
======================
(gpartedbin:15572): glibmm-CRITICAL **:
unhandled exception (type Glib::Error) in signal handler:
domain: g-shell-error-quark
code : 0
what : Text ended before matching quote was found for ". (The text was 'mkfs.xfs -f -L "mylabel" "
/dev/sdb8')
Creation of XFS file systems was broken by the extra stray double quote
added to the command before the device name, by commit:
63aeb150ace06f678241f514c550e51b22d2f823
Rename member variables and methods in Partition class (#741424)
Bug 744108 - Creating an XFS file system never completes
src/xfs.cc | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/src/xfs.cc b/src/xfs.cc
index 33b9bfe..9c1cd8d 100644
--- a/src/xfs.cc
+++ b/src/xfs.cc
@@ -173,10 +173,10 @@ bool xfs::write_uuid( const Partition & partition, OperationDetail & operationde
bool xfs::create( const Partition & new_partition, OperationDetail & operationdetail )
{
return ! execute_command( "mkfs.xfs -f -L \"" + new_partition.get_filesystem_label() + "\" " +
- "\" " + new_partition.get_path(),
- operationdetail,
- false,
- true );
+ new_partition.get_path(),
+ operationdetail,
+ false,
+ true );
}
bool xfs::resize( const Partition & partition_new, OperationDetail & operationdetail, bool fill_partition )
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]