[gnome-calendar/calendar-management] source-manager: remove sources.show action



commit a8964d59b38245d5d15fddb79a8301a62c4ba050
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Thu Feb 5 12:14:48 2015 -0200

    source-manager: remove sources.show action
    
    As asked by the design team, this duplicates functionality.

 data/ui/menus.ui                 |    4 ---
 src/gcal-source-manager-dialog.c |   40 --------------------------------------
 2 files changed, 0 insertions(+), 44 deletions(-)
---
diff --git a/data/ui/menus.ui b/data/ui/menus.ui
index 73d6f13..50ecbf5 100644
--- a/data/ui/menus.ui
+++ b/data/ui/menus.ui
@@ -62,10 +62,6 @@
   <menu id="editsourcemenu">
     <section>
       <item>
-        <attribute name="label" translatable="yes">Show</attribute>
-        <attribute name="action">sources.show</attribute>
-      </item>
-      <item>
         <attribute name="label" translatable="yes">Default Calendar</attribute>
         <attribute name="action">sources.default</attribute>
       </item>
diff --git a/src/gcal-source-manager-dialog.c b/src/gcal-source-manager-dialog.c
index 38bee02..a5f2687 100644
--- a/src/gcal-source-manager-dialog.c
+++ b/src/gcal-source-manager-dialog.c
@@ -89,10 +89,6 @@ static void     row_activated_cb                           (GtkListBox
                                                             GtkListBoxRow       *row,
                                                             gpointer             user_data);
 
-static void     show_action_state_changed                  (GSimpleAction       *menu_item,
-                                                            GVariant            *value,
-                                                            gpointer             user_data);
-
 static void     source_added_cb                            (GcalManager         *manager,
                                                             ESource             *source,
                                                             gboolean             enabled,
@@ -148,7 +144,6 @@ static GActionEntry action_entries[] =
   { "file", file_action_activated, NULL, NULL, NULL },
   { "local", local_action_activated, NULL, NULL, NULL },
   { "url", url_action_activated, NULL, NULL, NULL },
-  { "show", NULL, NULL, "false", show_action_state_changed },
   { "default", NULL, NULL, "false", default_action_state_changed },
   { "rename", NULL, NULL, NULL, NULL },
   { "color", color_action_activated, NULL, NULL, NULL },
@@ -458,41 +453,6 @@ row_activated_cb (GtkListBox    *listbox,
 }
 
 /**
- * show_action_state_changed:
- *
- * Update the source's enable/disable
- * state.
- *
- * Returns:
- */
-static void
-show_action_state_changed (GSimpleAction *menu_item,
-                           GVariant      *value,
-                           gpointer       user_data)
-{
-  GcalSourceManagerDialogPrivate *priv;
-  gboolean should_show;
-
-  priv = gcal_source_manager_dialog_get_instance_private (GCAL_SOURCE_MANAGER_DIALOG (user_data));
-  should_show = g_variant_get_boolean (value);
-
-  g_assert_nonnull (priv->selected_source);
-
-  if (priv->updating)
-      goto out;
-
-  /* Show/hide the source from the views */
-  if (should_show)
-    gcal_manager_enable_source (priv->manager, priv->selected_source);
-  else
-    gcal_manager_disable_source (priv->manager, priv->selected_source);
-
-out:
-  g_simple_action_set_state (menu_item, value);
-}
-
-
-/**
  * source_added_cb:
  *
  * Callback for when an #ESource is added


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]