[evolution-data-server] Correct error in credentials_prompter_dispose()



commit 5f5b45e1687fad3870784aa97a1aef0f6f76f9ea
Author: Milan Crha <mcrha redhat com>
Date:   Tue Feb 3 08:16:39 2015 +0100

    Correct error in credentials_prompter_dispose()
    
    A 'prompters' hash table has a gchar * as a key (an authentication method)
    and the prompter implementation object as a value, but the dispose, when
    disconnecting signal handlers, misplaced the value with key, leading to
    an invalid pointer being passed into the signal disconnect function.

 libedataserverui/e-credentials-prompter.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/libedataserverui/e-credentials-prompter.c b/libedataserverui/e-credentials-prompter.c
index f295e41..cc6724f 100644
--- a/libedataserverui/e-credentials-prompter.c
+++ b/libedataserverui/e-credentials-prompter.c
@@ -910,7 +910,7 @@ credentials_prompter_dispose (GObject *object)
 
        g_hash_table_iter_init (&iter, prompter->priv->prompters);
        while (g_hash_table_iter_next (&iter, &key, &value)) {
-               ECredentialsPrompterImpl *prompter_impl = key;
+               ECredentialsPrompterImpl *prompter_impl = value;
 
                g_signal_handlers_disconnect_by_func (prompter_impl, credentials_prompter_prompt_finished_cb, 
prompter);
        }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]