[eog] EogWindow: Cleanups for 254f4ba4
- From: Felix Riemann <friemann src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [eog] EogWindow: Cleanups for 254f4ba4
- Date: Mon, 2 Feb 2015 19:39:03 +0000 (UTC)
commit a86c990b8fff9714a313070d65d287879d45a875
Author: Felix Riemann <friemann gnome org>
Date: Mon Feb 2 20:36:17 2015 +0100
EogWindow: Cleanups for 254f4ba4
https://bugzilla.gnome.org/show_bug.cgi?id=741050
src/eog-window.c | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)
---
diff --git a/src/eog-window.c b/src/eog-window.c
index 75f4bfc..5329f95 100644
--- a/src/eog-window.c
+++ b/src/eog-window.c
@@ -1038,10 +1038,6 @@ eog_window_update_open_with_menu (EogWindow *window, EogImage *image)
/* Do not include eog itself */
if (g_ascii_strcasecmp (g_app_info_get_executable (app),
g_get_prgname ()) == 0) {
- /* FIXME: should we really unref this? We free the full
- * list below outside of the loop. If we should unref,
- * why don't we unref the others that do not pass the
- * above check? */
g_object_unref (app);
continue;
}
@@ -1059,10 +1055,10 @@ eog_window_update_open_with_menu (EogWindow *window, EogImage *image)
g_ptr_array_add (priv->appinfo, app);
g_menu_append_item (priv->open_with_menu, item);
g_object_unref (item);
- }
+ }
g_object_unref (file);
- g_list_free (apps);
+ g_list_free (apps);
}
static void
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]