[balsa/gtk3] Prune some dead code
- From: Peter Bloomfield <peterb src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [balsa/gtk3] Prune some dead code
- Date: Mon, 2 Feb 2015 14:20:37 +0000 (UTC)
commit 993b4f2e59f109bdd31fade60279f3365b0de525
Author: Peter Bloomfield <PeterBloomfield bellsouth net>
Date: Mon Feb 2 09:20:03 2015 -0500
Prune some dead code
* src/balsa-message.c (balsa_message_init), (balsa_message_new):
close-with-msg is unused.
* src/balsa-message.h: remove it, and its setter.
* src/message-window.c (message_window_idle_handler),
(mw_set_selected): setter has gone away.
ChangeLog | 10 ++++++++++
src/balsa-message.c | 7 -------
src/balsa-message.h | 4 ----
src/message-window.c | 6 ------
4 files changed, 10 insertions(+), 17 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 65ae2dc..202115e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,15 @@
2015-02-02 Peter Bloomfield <pbloomfield bellsouth net>
+ Prune some dead code
+
+ * src/balsa-message.c (balsa_message_init), (balsa_message_new):
+ close-with-msg is unused.
+ * src/balsa-message.h: remove it, and its setter.
+ * src/message-window.c (message_window_idle_handler),
+ (mw_set_selected): setter has gone away.
+
+2015-02-02 Peter Bloomfield <pbloomfield bellsouth net>
+
Compose window may outlive main window
* src/main-window.c (bw_send_msg_window_destroy_cb): check for
diff --git a/src/balsa-message.c b/src/balsa-message.c
index 4aed993..bad8237 100644
--- a/src/balsa-message.c
+++ b/src/balsa-message.c
@@ -793,7 +793,6 @@ balsa_message_init(BalsaMessage * bm)
bm->wrap_text = balsa_app.browse_wrap;
bm->shown_headers = balsa_app.shown_headers;
- bm->close_with_msg = FALSE;
gtk_widget_show_all(GTK_WIDGET(bm));
@@ -847,12 +846,6 @@ balsa_message_new(void)
return GTK_WIDGET(bm);
}
-void
-balsa_message_set_close(BalsaMessage * bm, gboolean close_with_msg)
-{
- bm->close_with_msg = close_with_msg;
-}
-
/* Returns a BalsaPartInfo with a reference (g_object_unref when done). */
static BalsaPartInfo *
tree_next_valid_part_info(GtkTreeModel * model, GtkTreeIter * iter)
diff --git a/src/balsa-message.h b/src/balsa-message.h
index 3e90b5c..80b65a2 100644
--- a/src/balsa-message.h
+++ b/src/balsa-message.h
@@ -79,8 +79,6 @@ struct _BalsaMessage {
LibBalsaMessage *message;
- gboolean close_with_msg;
-
BalsaMessageFocusState focus_state;
/* Find-in-message stuff */
@@ -112,8 +110,6 @@ struct _BalsaMessageClass {
GType balsa_message_get_type(void);
GtkWidget *balsa_message_new(void);
-void balsa_message_set_close(BalsaMessage * bmessage,
- gboolean close_with_msg);
gboolean balsa_message_set(BalsaMessage * bmessage,
LibBalsaMailbox * mailbox, guint msgno);
diff --git a/src/message-window.c b/src/message-window.c
index 0ca1873..900787a 100644
--- a/src/message-window.c
+++ b/src/message-window.c
@@ -125,7 +125,6 @@ message_window_idle_handler(MessageWindow * mw)
return FALSE;
}
balsa_message_grab_focus(msg);
- balsa_message_set_close(msg, TRUE);
gdk_threads_leave();
return FALSE;
@@ -613,11 +612,6 @@ mw_set_selected(MessageWindow * mw, void (*select_func) (BalsaIndex *))
gtk_widget_destroy(tmp->window);
}
- /* Temporarily tell the BalsaMessage not to close when its message
- * is finalized, so we can safely unref it in mw_set_message.
- * We'll restore the usual close-with-message behavior after setting
- * the new message. */
- balsa_message_set_close(BALSA_MESSAGE(mw->bmessage), FALSE);
mw_set_message(mw, message);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]