[gtk+] plugman: Fix leaking attribute string



commit f7803704993d1b306cb46052fd58fd02a9e20a23
Author: Felix Riemann <friemann gnome org>
Date:   Sat Jan 31 16:17:24 2015 +0100

    plugman: Fix leaking attribute string
    
    https://bugzilla.gnome.org/show_bug.cgi?id=743770

 examples/plugman.c |   13 ++++++++-----
 1 files changed, 8 insertions(+), 5 deletions(-)
---
diff --git a/examples/plugman.c b/examples/plugman.c
index e9c052a..53f502e 100644
--- a/examples/plugman.c
+++ b/examples/plugman.c
@@ -267,16 +267,19 @@ disable_plugin (const gchar *name)
   plugin_menu = find_plugin_menu ();
   if (plugin_menu)
     {
-      const gchar *id;
       gint i;
 
       for (i = 0; i < g_menu_model_get_n_items (plugin_menu); i++)
         {
-           if (g_menu_model_get_item_attribute (plugin_menu, i, "id", "s", &id) &&
-               g_strcmp0 (id, name) == 0)
+           gchar *id;
+           if (g_menu_model_get_item_attribute (plugin_menu, i, "id", "s", &id))
              {
-               g_menu_remove (G_MENU (plugin_menu), i);
-               g_print ("Menus of '%s' plugin removed\n", name);
+               if (g_strcmp0 (id, name) == 0)
+                 {
+                   g_menu_remove (G_MENU (plugin_menu), i);
+                   g_print ("Menus of '%s' plugin removed\n", name);
+                 }
+               g_free (id);
              }
         }
     }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]