[mutter] window: Update the stack after setting the transient_for field
- From: Jonas Ådahl <jadahl src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [mutter] window: Update the stack after setting the transient_for field
- Date: Wed, 23 Dec 2015 07:31:22 +0000 (UTC)
commit 213f0fa160f1d9407e46cc36816132043a9369dc
Author: Jonas Ådahl <jadahl gmail com>
Date: Thu Sep 24 13:35:42 2015 +0800
window: Update the stack after setting the transient_for field
Don't update the stack until after setting the window->transient_for
field. Updating before will cause the stack transient-for constraint to
be missing until the next time constraints are applied.
https://bugzilla.gnome.org/show_bug.cgi?id=755606
src/core/window.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/src/core/window.c b/src/core/window.c
index b21b6bb..25cc5b8 100644
--- a/src/core/window.c
+++ b/src/core/window.c
@@ -7417,14 +7417,14 @@ meta_window_set_transient_for (MetaWindow *window,
}
}
- /* update stacking constraints */
- if (!window->override_redirect)
- meta_stack_update_transient (window->screen->stack, window);
-
/* We know this won't create a reference cycle because we check for loops */
g_clear_object (&window->transient_for);
window->transient_for = parent ? g_object_ref (parent) : NULL;
+ /* update stacking constraints */
+ if (!window->override_redirect)
+ meta_stack_update_transient (window->screen->stack, window);
+
/* possibly change its group. We treat being a window's transient as
* equivalent to making it your group leader, to work around shortcomings
* in programs such as xmms-- see #328211.
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]