[pitivi] pipeline: Don't call directly callback methods



commit 1af2040d134361d1d10709edd0f1a202a6dcc9af
Author: Alexandru Băluț <alexandru balut gmail com>
Date:   Thu Nov 5 17:38:59 2015 +0100

    pipeline: Don't call directly callback methods
    
    Reviewed-by: Thibault Saunier <tsaunier gnome org>
    Differential Revision: https://phabricator.freedesktop.org/D557

 pitivi/utils/pipeline.py |   11 +++++++----
 1 files changed, 7 insertions(+), 4 deletions(-)
---
diff --git a/pitivi/utils/pipeline.py b/pitivi/utils/pipeline.py
index 4d85809..a7e0b30 100644
--- a/pitivi/utils/pipeline.py
+++ b/pitivi/utils/pipeline.py
@@ -99,9 +99,9 @@ class Seeker(GObject.Object, Loggable):
         if self.pending_seek_id is None:
             if on_idle:
                 self.pending_seek_id = self._scheduleSeek(
-                    self.timeout, self._seekTimeoutCb)
+                    self.timeout, self._seekTimeoutCb, relative=False)
             else:
-                self._seekTimeoutCb()
+                self._seek(relative=False)
         else:
             self.pending_position = position
 
@@ -112,7 +112,7 @@ class Seeker(GObject.Object, Loggable):
                 self.pending_seek_id = self._scheduleSeek(
                     self.timeout, self._seekTimeoutCb, relative=True)
             else:
-                self._seekTimeoutCb(relative=True)
+                self._seek(relative=True)
 
     def flush(self, on_idle=False):
         self.seekRelative(0, on_idle)
@@ -120,7 +120,10 @@ class Seeker(GObject.Object, Loggable):
     def _scheduleSeek(self, timeout, callback, relative=False):
         return GLib.timeout_add(timeout, callback, relative)
 
-    def _seekTimeoutCb(self, relative=False):
+    def _seekTimeoutCb(self, relative):
+        self._seek(relative)
+
+    def _seek(self, relative):
         self.pending_seek_id = None
 
         if relative:


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]