[meld: 6/63] filediff: Remove progress callback until we support network mounts



commit 96d6cc7cab645ec7f4b7d1a43737330597a3d34a
Author: Kai Willadsen <kai willadsen gmail com>
Date:   Sun Jul 19 08:53:59 2015 +1000

    filediff: Remove progress callback until we support network mounts
    
    Reasonable (and even unreasonable) files load quickly enough that
    there's just not a lot of motivation to show progress updates, and it's
    not trivial to get right. Once we support network mounts, etc. this
    will be a much more pressing concern.

 meld/filediff.py |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)
---
diff --git a/meld/filediff.py b/meld/filediff.py
index ab65933..e7d5182 100644
--- a/meld/filediff.py
+++ b/meld/filediff.py
@@ -1061,18 +1061,12 @@ class FileDiff(melddoc.MeldDoc, gnomeglade.Component):
 
             # TODO: Maybe re-add support for the 'detect-encodings' gsetting
             loader = GtkSource.FileLoader.new(textbuffers[pane], sourcefile)
-            # FIXME: add a cancelable
             loader.load_async(
                 GLib.PRIORITY_HIGH,
-                progress_callback=self.load_progress,
-                progress_callback_data=(pane,),
                 callback=self.file_loaded,
                 user_data=(pane,)
             )
 
-    def load_progress(self, current_bytes, total_bytes, pane):
-        print pane, "%d%%" % int((current_bytes / float(total_bytes)) * 100)
-
     def file_loaded(self, loader, result, user_data):
 
         gfile = loader.get_location()


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]