[gnome-boxes] app-window: Drop alt+a kbd shortcut
- From: Zeeshan Ali Khattak <zeeshanak src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-boxes] app-window: Drop alt+a kbd shortcut
- Date: Tue, 15 Dec 2015 21:16:06 +0000 (UTC)
commit ec60b406903b9bb604f40a51434d01d69011e732
Author: Zeeshan Ali (Khattak) <zeeshanak gnome org>
Date: Mon Dec 14 19:51:58 2015 +0000
app-window: Drop alt+a kbd shortcut
We already support alt+q for quitting the UI and it's well-known, there
is no reason to have two shortcuts for the same thing. So let's just
drop alt+a shortcut. Relevant IRC discussion:
<aday> zeenix: why Alt+A for quit?
<mclasen> aday: A für Aufhören!
<mclasen> or maybe a for abort
<aday> zeenix: but you already have ctrl+q. why do you need alt+a too?
<zeenix> aday: i guess idea was to add support for all known key combos
<aday> zeenix: i didn't know that alt+a was known... not sure why
you'd need two combos for the same action
<aday> zeenix: i'd try and avoid duplicating shortcuts in the
shortcuts window.
data/ui/kbd-shortcuts-window.ui | 4 ++--
src/app-window.vala | 5 -----
2 files changed, 2 insertions(+), 7 deletions(-)
---
diff --git a/data/ui/kbd-shortcuts-window.ui b/data/ui/kbd-shortcuts-window.ui
index 73f455c..bb1a2a4 100644
--- a/data/ui/kbd-shortcuts-window.ui
+++ b/data/ui/kbd-shortcuts-window.ui
@@ -44,7 +44,7 @@
<child>
<object class="GtkShortcutsShortcut">
<property name="visible">1</property>
- <property name="accelerator"><Ctrl>q <Alt>a</property>
+ <property name="accelerator"><Ctrl>q</property>
<property name="title" translatable="yes">Close Window/Quit Boxes</property>
</object>
</child>
@@ -142,7 +142,7 @@
<child>
<object class="GtkShortcutsShortcut">
<property name="visible">1</property>
- <property name="accelerator"><Ctrl>q <Alt>a</property>
+ <property name="accelerator"><Ctrl>q</property>
<property name="title" translatable="yes">Close window/Quit Boxes</property>
</object>
</child>
diff --git a/src/app-window.vala b/src/app-window.vala
index 08e2e92..021948c 100644
--- a/src/app-window.vala
+++ b/src/app-window.vala
@@ -363,11 +363,6 @@ private class Boxes.AppWindow: Gtk.ApplicationWindow, Boxes.UI {
topbar.click_search_button ();
return true;
- } else if (event.keyval == Gdk.Key.a &&
- (event.state & default_modifiers) == Gdk.ModifierType.MOD1_MASK) {
- App.app.quit_app ();
-
- return true;
} else if (((direction == Gtk.TextDirection.LTR && // LTR
event.keyval == Gdk.Key.Left) || // ALT + Left -> back
(direction == Gtk.TextDirection.RTL && // RTL
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]