[file-roller/gnome-3-16] Fix query_info_ready_for_overwrite_dialog_cb memory leak



commit 4e7bf9ef88155a77d193017c49655eb7cb97bb28
Author: David King <dking redhat com>
Date:   Thu Jul 16 10:50:54 2015 +0100

    Fix query_info_ready_for_overwrite_dialog_cb memory leak
    
    Found with Valgrind:
    
    ==9376== 65 bytes in 1 blocks are definitely lost in loss record 11,501
    of 17,916
    ==9376==    at 0x4C2DB9D: realloc (in
    /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
    ==9376==    by 0x7FB1F9A: vasprintf (in /usr/lib64/libc-2.21.90.so)
    ==9376==    by 0x74C8E90: g_vasprintf (gprintf.c:316)
    ==9376==    by 0x74A43CF: g_strdup_vprintf (gstrfuncs.c:507)
    ==9376==    by 0x74A446B: g_strdup_printf (gstrfuncs.c:533)
    ==9376==    by 0x446556: query_info_ready_for_overwrite_dialog_cb
    (fr-window.c:6496)
    ==9376==    by 0x6EEA4E8: g_task_return_now (gtask.c:1104)
    ==9376==    by 0x6EEA528: complete_in_idle_cb (gtask.c:1118)
    ==9376==    by 0x7485C89: g_main_dispatch (gmain.c:3122)
    ==9376==    by 0x7485C89: g_main_context_dispatch (gmain.c:3737)
    ==9376==    by 0x7486007: g_main_context_iterate.isra.29 (gmain.c:3808)
    ==9376==    by 0x74860AB: g_main_context_iteration (gmain.c:3869)
    ==9376==    by 0x6F0F5BB: g_application_run (gapplication.c:2311)
    ==9376==    by 0x414FE5: main (main.c:38)
    
    https://bugzilla.gnome.org/show_bug.cgi?id=752476

 src/fr-window.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
---
diff --git a/src/fr-window.c b/src/fr-window.c
index 735c9fa..26555dc 100644
--- a/src/fr-window.c
+++ b/src/fr-window.c
@@ -6500,7 +6500,9 @@ query_info_ready_for_overwrite_dialog_cb (GObject      *source_object,
                                  odata);
                gtk_widget_show (d);
 
+               g_free (msg);
                g_free (parent_name);
+               g_free (details);
                g_object_unref (parent);
                g_object_unref (info);
                g_object_unref (destination);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]