[nautilus/gnome-3-18] window-slot: don't increase references on dispose...



commit baaa7370bcb2c84fd92e43e1eb6a41f64cd06a2e
Author: Carlos Soriano <csoriano gnome org>
Date:   Fri Dec 11 23:00:18 2015 +0100

    window-slot: don't increase references on dispose...
    
    It's clearly wrong. The TODO doesn't make it better :)
    We are leaking few of GFiles already...

 src/nautilus-window-slot.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)
---
diff --git a/src/nautilus-window-slot.c b/src/nautilus-window-slot.c
index d005eee..98907b5 100644
--- a/src/nautilus-window-slot.c
+++ b/src/nautilus-window-slot.c
@@ -2290,11 +2290,7 @@ nautilus_window_slot_dispose (GObject *object)
         * It was already here before the slot move, though */
        nautilus_file_unref (slot->details->viewed_file);
 
-       if (slot->details->location) {
-               /* TODO? why do we ref here, instead of unreffing?
-                * It was already here before the slot migration, though */
-               g_object_ref (slot->details->location);
-       }
+        g_clear_object (&slot->details->location);
 
         if (slot->details->view_mode_before_search) {
                 g_free (slot->details->view_mode_before_search);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]