[file-roller] File Roller crashes on drag'n'drop



commit 14c7ed8d6f616ea6e8cf40488e843cec4f23e55f
Author: Paolo Bacchilega <paobac src gnome org>
Date:   Fri Aug 28 16:34:47 2015 +0200

    File Roller crashes on drag'n'drop
    
    create a new string instead of adding a 0 at the end of the returned
    value
    
    [bug #746236]

 src/fr-window.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
---
diff --git a/src/fr-window.c b/src/fr-window.c
index b9f128f..a0b7377 100644
--- a/src/fr-window.c
+++ b/src/fr-window.c
@@ -4230,6 +4230,7 @@ file_list_drag_end (GtkWidget      *widget,
 static char *
 get_xds_atom_value (GdkDragContext *context)
 {
+       char *data = NULL;
        char *ret;
        int   len;
 
@@ -4242,11 +4243,11 @@ get_xds_atom_value (GdkDragContext *context)
                              FALSE, NULL, NULL, &len,
                              (unsigned char **) &ret))
        {
-               ret[len] = '\0';
-               return ret;
+               data = g_strndup (ret, len);
+               g_free (ret);
        }
 
-       return NULL;
+       return data;
 }
 
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]