[gnome-software] Remove margins in the Add to Folder and Updates dialogs



commit 5ee44644c702db91dad20b7d572c1a2c9460e48f
Author: Rafal Luzynski <digitalfreak lingonborough com>
Date:   Sat Aug 15 03:31:27 2015 +0200

    Remove margins in the Add to Folder and Updates dialogs
    
    Remove unnecessary margins, shadows, borders, frames etc. to unify
    the appearance of these two dialog boxes with the main application
    window.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=728670

 src/app-folder-dialog.ui |    8 +++-----
 src/gs-update-dialog.c   |    4 ----
 src/gs-update-dialog.ui  |   16 ++++++++--------
 3 files changed, 11 insertions(+), 17 deletions(-)
---
diff --git a/src/app-folder-dialog.ui b/src/app-folder-dialog.ui
index d1cc066..b1b31cd 100644
--- a/src/app-folder-dialog.ui
+++ b/src/app-folder-dialog.ui
@@ -4,6 +4,7 @@
   <template class="GsAppFolderDialog" parent="GtkDialog">
     <property name="title" translatable="yes">Add to Application Folder</property>
     <property name="default-height">500</property>
+    <property name="default-width">460</property>
     <property name="type-hint">dialog</property>
     <property name="modal">True</property>
     <property name="resizable">True</property>
@@ -27,13 +28,10 @@
     </child>
     <child internal-child="vbox">
       <object class="GtkBox">
+        <property name="border-width">0</property>
         <child>
           <object class="GtkScrolledWindow" id="scrolledwindow">
             <property name="visible">True</property>
-            <property name="margin-top">15</property>
-            <property name="margin-bottom">15</property>
-            <property name="margin-start">12</property>
-            <property name="margin-end">12</property>
             <property name="hscrollbar_policy">never</property>
             <property name="vscrollbar_policy">automatic</property>
             <property name="shadow_type">none</property>
@@ -41,7 +39,7 @@
             <child>
               <object class="GtkFrame" id="frame">
                 <property name="visible">True</property>
-                <property name="shadow_type">in</property>
+                <property name="shadow_type">none</property>
                 <property name="halign">fill</property>
                 <property name="valign">start</property>
                 <style>
diff --git a/src/gs-update-dialog.c b/src/gs-update-dialog.c
index 547aee1..2265ac5 100644
--- a/src/gs-update-dialog.c
+++ b/src/gs-update-dialog.c
@@ -455,10 +455,6 @@ gs_update_dialog_init (GsUpdateDialog *dialog)
        scrollbar = gtk_scrolled_window_get_vscrollbar (GTK_SCROLLED_WINDOW (priv->scrolledwindow_details));
        g_signal_connect (scrollbar, "map", G_CALLBACK (scrollbar_mapped_cb), priv->scrolledwindow_details);
        g_signal_connect (scrollbar, "unmap", G_CALLBACK (scrollbar_mapped_cb), priv->scrolledwindow_details);
-
-       scrollbar = gtk_scrolled_window_get_vscrollbar (GTK_SCROLLED_WINDOW (priv->scrolledwindow));
-       g_signal_connect (scrollbar, "map", G_CALLBACK (scrollbar_mapped_cb), priv->scrolledwindow);
-       g_signal_connect (scrollbar, "unmap", G_CALLBACK (scrollbar_mapped_cb), priv->scrolledwindow);
 }
 
 static void
diff --git a/src/gs-update-dialog.ui b/src/gs-update-dialog.ui
index 0d632b5..70f49ee 100644
--- a/src/gs-update-dialog.ui
+++ b/src/gs-update-dialog.ui
@@ -42,10 +42,7 @@
     <child internal-child="vbox">
       <object class="GtkBox" id="dialog-vbox1">
         <property name="can_focus">False</property>
-        <property name="margin_start">6</property>
-        <property name="margin_end">6</property>
-        <property name="margin_top">6</property>
-        <property name="margin_bottom">6</property>
+        <property name="border_width">0</property>
         <property name="orientation">vertical</property>
         <property name="spacing">2</property>
         <child>
@@ -131,8 +128,11 @@
               <object class="GtkBox" id="box7">
                 <property name="visible">True</property>
                 <property name="can_focus">False</property>
-                <property name="margin_bottom">3</property>
-                <property name="border_width">3</property>
+                <property name="margin_start">6</property>
+                <property name="margin_end">6</property>
+                <property name="margin_top">6</property>
+                <property name="margin_bottom">9</property>
+                <property name="border_width">5</property>
                 <property name="orientation">vertical</property>
                 <property name="spacing">9</property>
                 <child>
@@ -257,7 +257,7 @@
                 <child>
                   <object class="GtkFrame" id="box_update_frame">
                     <property name="visible">True</property>
-                    <property name="shadow_type">in</property>
+                    <property name="shadow_type">none</property>
                     <property name="halign">fill</property>
                     <property name="valign">start</property>
                     <style>
@@ -288,7 +288,7 @@
                 <child>
                   <object class="GtkFrame" id="frame_installed_updates">
                     <property name="visible">True</property>
-                    <property name="shadow_type">in</property>
+                    <property name="shadow_type">none</property>
                     <property name="halign">fill</property>
                     <property name="valign">start</property>
                     <style>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]