[gedit] strdup in the calleee instead of the caller



commit 038818632a39d9d0395db226e567a91a13623290
Author: Paolo Borelli <pborelli gnome org>
Date:   Fri Aug 14 08:57:56 2015 +0200

    strdup in the calleee instead of the caller

 gedit/gedit-open-document-selector-store.c |    4 ++--
 gedit/gedit-open-document-selector-store.h |    2 +-
 gedit/gedit-open-document-selector.c       |    2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/gedit/gedit-open-document-selector-store.c b/gedit/gedit-open-document-selector-store.c
index 2260c38..d990d50 100644
--- a/gedit/gedit-open-document-selector-store.c
+++ b/gedit/gedit-open-document-selector-store.c
@@ -758,7 +758,7 @@ gedit_open_document_selector_store_get_recent_limit (GeditOpenDocumentSelectorSt
 
 void
 gedit_open_document_selector_store_set_recent_filter (GeditOpenDocumentSelectorStore *selector_store,
-                                                      gchar                          *filter)
+                                                      const gchar                    *filter)
 {
        gchar *old_filter;
 
@@ -768,7 +768,7 @@ gedit_open_document_selector_store_set_recent_filter (GeditOpenDocumentSelectorS
        G_LOCK (recent_files_filter_lock);
 
        old_filter = selector_store->recent_config.substring_filter;
-       selector_store->recent_config.substring_filter = filter;
+       selector_store->recent_config.substring_filter = g_strdup (filter);
 
        G_UNLOCK (recent_files_filter_lock);
        g_free (old_filter);
diff --git a/gedit/gedit-open-document-selector-store.h b/gedit/gedit-open-document-selector-store.h
index 6d85bb1..6a0212d 100644
--- a/gedit/gedit-open-document-selector-store.h
+++ b/gedit/gedit-open-document-selector-store.h
@@ -45,7 +45,7 @@ GQuark                                 gedit_open_document_selector_store_error_quark       
                  (void);
 gint                            gedit_open_document_selector_store_get_recent_limit                    
(GeditOpenDocumentSelectorStore *store);
 
 void                            gedit_open_document_selector_store_set_recent_filter                   
(GeditOpenDocumentSelectorStore *store,
-                                                                                                         
gchar                          *filter);
+                                                                                                         
const gchar                    *filter);
 
 gchar                          *gedit_open_document_selector_store_get_recent_filter                   
(GeditOpenDocumentSelectorStore *store);
 
diff --git a/gedit/gedit-open-document-selector.c b/gedit/gedit-open-document-selector.c
index 340e82b..917481b 100644
--- a/gedit/gedit-open-document-selector.c
+++ b/gedit/gedit-open-document-selector.c
@@ -626,7 +626,7 @@ on_entry_changed (GtkEntry                  *entry,
 
        entry_text = gtk_entry_get_text (entry);
        gedit_open_document_selector_store_set_recent_filter (selector->selector_store,
-                                                             g_strdup (entry_text));
+                                                             entry_text);
 
        if (gtk_widget_get_mapped ( GTK_WIDGET (selector)))
        {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]