[libsoup/wip/xmlrpc-variant: 11/18] xmlrpc: remove soup_xmlrpc_new_custom from public API



commit e103432b0371dccd5af41b1a6fcdb200784f7f93
Author: Xavier Claessens <xavier claessens collabora com>
Date:   Mon Aug 10 14:22:41 2015 -0400

    xmlrpc: remove soup_xmlrpc_new_custom from public API
    
    It is premature to add it, it wasn't supported in old API
    and custom types cannot be parsed. API can be extended later
    if there is a need.

 docs/reference/libsoup-2.4-sections.txt |    1 -
 libsoup/libsoup-2.4.sym                 |    1 -
 libsoup/soup-xmlrpc.c                   |   24 ++++--------------------
 libsoup/soup-xmlrpc.h                   |    3 ---
 4 files changed, 4 insertions(+), 25 deletions(-)
---
diff --git a/docs/reference/libsoup-2.4-sections.txt b/docs/reference/libsoup-2.4-sections.txt
index a35d9dc..cee1388 100644
--- a/docs/reference/libsoup-2.4-sections.txt
+++ b/docs/reference/libsoup-2.4-sections.txt
@@ -838,7 +838,6 @@ SoupXMLRPCFault
 soup_xmlrpc_build_request
 soup_xmlrpc_message_new
 soup_xmlrpc_parse_response
-soup_xmlrpc_new_custom
 soup_xmlrpc_new_datetime
 <SUBSECTION>
 SoupXMLRPCParams
diff --git a/libsoup/libsoup-2.4.sym b/libsoup/libsoup-2.4.sym
index eacd2d5..c9b35b8 100644
--- a/libsoup/libsoup-2.4.sym
+++ b/libsoup/libsoup-2.4.sym
@@ -554,7 +554,6 @@ soup_xmlrpc_fault_quark
 soup_xmlrpc_message_new
 soup_xmlrpc_message_set_fault
 soup_xmlrpc_message_set_response
-soup_xmlrpc_new_custom
 soup_xmlrpc_new_datetime
 soup_xmlrpc_params_free
 soup_xmlrpc_params_parse
diff --git a/libsoup/soup-xmlrpc.c b/libsoup/soup-xmlrpc.c
index 5bedaf2..e62deb2 100644
--- a/libsoup/soup-xmlrpc.c
+++ b/libsoup/soup-xmlrpc.c
@@ -1409,25 +1409,6 @@ fail:
 }
 
 /**
- * soup_xmlrpc_new_custom:
- * @type: name for the type node
- * @value: value for the type node
- *
- * Construct a special #GVariant used to serialize a &lt;@type&gt;
- * node containing @value. See soup_xmlrpc_build_request().
- *
- * Returns: a floating #GVariant.
- *
- * Since: 2.52
- */
-GVariant *
-soup_xmlrpc_new_custom (const char *type, const char *value)
-{
-       return g_variant_new ("(oss)", "/org/gnome/libsoup/ExtensionType",
-                             type, value);
-}
-
-/**
  * soup_xmlrpc_new_datetime:
  * @timestamp: a unix timestamp
  *
@@ -1447,7 +1428,10 @@ soup_xmlrpc_new_datetime (time_t timestamp)
 
        date = soup_date_new_from_time_t (timestamp);
        str = soup_date_to_string (date, SOUP_DATE_ISO8601_XMLRPC);
-       variant = soup_xmlrpc_new_custom ("dateTime.iso8601", str);
+       variant = g_variant_new ("(oss)",
+                                "/org/gnome/libsoup/ExtensionType",
+                                "dateTime.iso8601",
+                                str);
        soup_date_free (date);
        g_free (str);
 
diff --git a/libsoup/soup-xmlrpc.h b/libsoup/soup-xmlrpc.h
index aa94339..e7ee73e 100644
--- a/libsoup/soup-xmlrpc.h
+++ b/libsoup/soup-xmlrpc.h
@@ -64,9 +64,6 @@ void         soup_xmlrpc_message_set_fault    (SoupMessage       *msg,
 
 /* Utils */
 SOUP_AVAILABLE_IN_2_52
-GVariant *soup_xmlrpc_new_custom   (const char *type,
-                                   const char *value);
-SOUP_AVAILABLE_IN_2_52
 GVariant *soup_xmlrpc_new_datetime (time_t       timestamp);
 
 /* Errors */


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]