[gnome-music] Improve logging



commit 57cbd98d98f18a88037528a3c97f1fc631432c5d
Author: Vadim Rutkovsky <vrutkovs redhat com>
Date:   Wed Aug 5 09:54:39 2015 +0200

    Improve logging

 gnomemusic/__init__.py |   11 ++++++-----
 gnomemusic/player.py   |    1 +
 2 files changed, 7 insertions(+), 5 deletions(-)
---
diff --git a/gnomemusic/__init__.py b/gnomemusic/__init__.py
index 55ea78d..1787055 100644
--- a/gnomemusic/__init__.py
+++ b/gnomemusic/__init__.py
@@ -41,23 +41,24 @@ def log(fn):
 
     def wrapped(*v, **k):
         global tabbing
-        name = fn.__name__
-        module = fn.__module__
+        name = fn.__qualname__
         filename = fn.__code__.co_filename.split('/')[-1]
         lineno = fn.__code__.co_firstlineno
 
         params = ", ".join(map(repr, chain(v, k.values())))
 
+        logger.debug("%s%s(%s)[%s:%s]",
+                     '|' * tabbing, name, params, filename, lineno,)
         tabbing += 1
         start = time.time()
         retval = fn(*v, **k)
         elapsed = time.time() - start
         tabbing -= 1
         elapsed_time = ''
-        if elapsed > 0.5:
+        if elapsed > 0.1:
             elapsed_time = ', took %02f' % elapsed
-        logger.debug("%s:%s\t%s%s.%s(%s), returned %s%s",
-                     filename, lineno, '|' * tabbing, module, name, params, retval, elapsed_time)
+        if elapsed_time or retval is not None:
+            logger.debug("%s  returned %s%s", '|' * tabbing, repr(retval), elapsed_time)
 
         return retval
     return wrapped
diff --git a/gnomemusic/player.py b/gnomemusic/player.py
index ceb29d5..0a3b082 100644
--- a/gnomemusic/player.py
+++ b/gnomemusic/player.py
@@ -1099,6 +1099,7 @@ class MissingCodecsDialog(Gtk.MessageDialog):
                                             "%s are required to play the file, but are not installed.",
                                             n_codecs) % text)
 
+
 class SelectionToolbar():
 
     @log



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]