[libgovirt] examples: Fix GError leak in error cases



commit cd0375f89803bf22531b102dbaaf0f02c050b847
Author: Christophe Fergeau <cfergeau redhat com>
Date:   Mon Jul 27 11:54:21 2015 +0200

    examples: Fix GError leak in error cases
    
    This cleans up valgrind output.

 examples/async-test.c     |    8 ++++++++
 examples/list-vms-async.c |    4 ++++
 examples/list-vms.c       |    2 ++
 3 files changed, 14 insertions(+), 0 deletions(-)
---
diff --git a/examples/async-test.c b/examples/async-test.c
index a20b16b..cca25d1 100644
--- a/examples/async-test.c
+++ b/examples/async-test.c
@@ -58,6 +58,7 @@ static void updated_cdrom_cb(GObject *source_object,
                               result, &error);
     if (error != NULL) {
         g_debug("failed to update cdrom resource: %s", error->message);
+        g_error_free(error);
     }
 
     g_main_loop_quit(main_loop);
@@ -78,6 +79,7 @@ static void cdroms_fetched_cb(GObject *source_object,
     ovirt_collection_fetch_finish(cdroms, result, &error);
     if (error != NULL) {
         g_debug("failed to fetch cdroms collection: %s", error->message);
+        g_error_free(error);
         g_main_loop_quit(main_loop);
         return;
     }
@@ -112,6 +114,7 @@ static void got_ticket_cb(GObject *source_object,
     ovirt_vm_get_ticket_finish(vm, result, &error);
     if (error != NULL) {
         g_debug("failed to fetch ticket for VM: %s", error->message);
+        g_error_free(error);
         g_main_loop_quit(main_loop);
         return;
     }
@@ -157,6 +160,7 @@ static void vm_started_cb(GObject *source_object,
     ovirt_vm_start_finish(vm, result, &error);
     if (error != NULL) {
         g_debug("failed to start VM: %s", error->message);
+        g_error_free(error);
         g_main_loop_quit(main_loop);
         return;
     }
@@ -178,6 +182,7 @@ static void vms_fetched_cb(GObject *source_object,
     ovirt_collection_fetch_finish(vms, result, &error);
     if (error != NULL) {
         g_debug("failed to fetch VMs: %s", error->message);
+        g_error_free(error);
         g_main_loop_quit(main_loop);
         return;
     }
@@ -195,6 +200,7 @@ static void vms_fetched_cb(GObject *source_object,
         ovirt_vm_start_async(vm, data->proxy, NULL, vm_started_cb, data);
         if (error != NULL) {
             g_debug("failed to start VM: %s", error->message);
+            g_error_free(error);
             g_main_loop_quit(main_loop);
             return;
         }
@@ -218,6 +224,7 @@ static void api_fetched_cb(GObject *source_object,
     api = ovirt_proxy_fetch_api_finish(proxy, result, &error);
     if (error != NULL) {
         g_debug("failed to fetch api: %s", error->message);
+        g_error_free(error);
         g_main_loop_quit(main_loop);
         return;
     }
@@ -241,6 +248,7 @@ static void fetched_ca_cert_cb(GObject *source_object,
     ca_cert = ovirt_proxy_fetch_ca_certificate_finish(proxy, result, &error);
     if (error != NULL) {
         g_debug("failed to get CA certificate: %s", error->message);
+        g_error_free(error);
         g_main_loop_quit(main_loop);
         return;
     }
diff --git a/examples/list-vms-async.c b/examples/list-vms-async.c
index 717f734..83fb9fa 100644
--- a/examples/list-vms-async.c
+++ b/examples/list-vms-async.c
@@ -80,6 +80,7 @@ static void pools_fetched_cb(GObject *source_object,
     ovirt_collection_fetch_finish(pools, result, &error);
     if (error != NULL) {
         g_debug("failed to fetch pools: %s", error->message);
+        g_error_free(error);
         g_main_loop_quit(main_loop);
         return;
     }
@@ -103,6 +104,7 @@ static void vms_fetched_cb(GObject *source_object,
     ovirt_collection_fetch_finish(vms, result, &error);
     if (error != NULL) {
         g_debug("failed to fetch VMs: %s", error->message);
+        g_error_free(error);
         g_main_loop_quit(main_loop);
         return;
     }
@@ -128,6 +130,7 @@ static void api_fetched_cb(GObject *source_object,
     data->api = ovirt_proxy_fetch_api_finish(proxy, result, &error);
     if (error != NULL) {
         g_debug("failed to fetch api: %s", error->message);
+        g_error_free(error);
         g_main_loop_quit(main_loop);
         return;
     }
@@ -151,6 +154,7 @@ static void fetched_ca_cert_cb(GObject *source_object,
     ca_cert = ovirt_proxy_fetch_ca_certificate_finish(proxy, result, &error);
     if (error != NULL) {
         g_debug("failed to get CA certificate: %s", error->message);
+        g_error_free(error);
         g_main_loop_quit(main_loop);
         return;
     }
diff --git a/examples/list-vms.c b/examples/list-vms.c
index 58f7722..6df8d8b 100644
--- a/examples/list-vms.c
+++ b/examples/list-vms.c
@@ -66,6 +66,7 @@ static void dump_vms(OvirtApi *api, OvirtProxy *proxy)
     ovirt_collection_fetch(vms, proxy, &error);
     if (error != NULL) {
         g_debug("failed to fetch VMs: %s", error->message);
+        g_error_free(error);
         return;
     }
 
@@ -84,6 +85,7 @@ static void dump_vm_pools(OvirtApi *api, OvirtProxy *proxy)
     ovirt_collection_fetch(pools, proxy, &error);
     if (error != NULL) {
         g_debug("failed to fetch VM pools: %s", error->message);
+        g_error_free(error);
         return;
     }
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]