[gedit/wip/tab-improve-timer: 1/2] tab: improve code readability in info_bar_set_progress()



commit 15a884a991c2db3bad38f542168fd7ed6c5713c9
Author: Sébastien Wilmet <swilmet gnome org>
Date:   Tue Apr 28 16:13:22 2015 +0200

    tab: improve code readability in info_bar_set_progress()

 gedit/gedit-tab.c |   28 +++++++++++++---------------
 1 files changed, 13 insertions(+), 15 deletions(-)
---
diff --git a/gedit/gedit-tab.c b/gedit/gedit-tab.c
index 742fd8b..a6232fd 100644
--- a/gedit/gedit-tab.c
+++ b/gedit/gedit-tab.c
@@ -922,6 +922,8 @@ info_bar_set_progress (GeditTab *tab,
                       goffset   size,
                       goffset   total_size)
 {
+       GeditProgressInfoBar *progress_info_bar;
+
        if (tab->info_bar == NULL)
        {
                return;
@@ -931,25 +933,21 @@ info_bar_set_progress (GeditTab *tab,
 
        g_return_if_fail (GEDIT_IS_PROGRESS_INFO_BAR (tab->info_bar));
 
-       if (total_size == 0)
+       progress_info_bar = GEDIT_PROGRESS_INFO_BAR (tab->info_bar);
+
+       if (total_size != 0)
        {
-               if (size != 0)
-                       gedit_progress_info_bar_pulse (
-                                       GEDIT_PROGRESS_INFO_BAR (tab->info_bar));
-               else
-                       gedit_progress_info_bar_set_fraction (
-                               GEDIT_PROGRESS_INFO_BAR (tab->info_bar),
-                               0);
+               gdouble frac = (gdouble)size / (gdouble)total_size;
+
+               gedit_progress_info_bar_set_fraction (progress_info_bar, frac);
+       }
+       else if (size != 0)
+       {
+               gedit_progress_info_bar_pulse (progress_info_bar);
        }
        else
        {
-               gdouble frac;
-
-               frac = (gdouble)size / (gdouble)total_size;
-
-               gedit_progress_info_bar_set_fraction (
-                               GEDIT_PROGRESS_INFO_BAR (tab->info_bar),
-                               frac);
+               gedit_progress_info_bar_set_fraction (progress_info_bar, 0);
        }
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]