[gnome-builder] app: propagate error failure



commit 0657692ec467317710419181773aa0217b9bd933
Author: Christian Hergert <christian hergert me>
Date:   Sun Apr 26 18:58:56 2015 -0700

    app: propagate error failure

 src/app/gb-application.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)
---
diff --git a/src/app/gb-application.c b/src/app/gb-application.c
index 8f85aae..92c250e 100644
--- a/src/app/gb-application.c
+++ b/src/app/gb-application.c
@@ -239,7 +239,6 @@ gb_application__context_new_cb (GObject      *object,
   GbApplication *self;
   GbWorkbench *workbench;
   GPtrArray *ar;
-  gboolean ret = FALSE;
   GError *error = NULL;
   gsize i;
 
@@ -255,8 +254,7 @@ gb_application__context_new_cb (GObject      *object,
 
   if (!context)
     {
-      g_warning ("%s", error->message);
-      g_clear_error (&error);
+      g_task_return_error (task, error);
       goto cleanup;
     }
 
@@ -292,10 +290,9 @@ gb_application__context_new_cb (GObject      *object,
 
   gtk_window_present (GTK_WINDOW (workbench));
 
-  ret = TRUE;
+  g_task_return_boolean (task, TRUE);
 
 cleanup:
-  g_task_return_boolean (task, ret);
   g_application_unmark_busy (G_APPLICATION (self));
   g_application_release (G_APPLICATION (self));
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]