[gedit] EncodingsDialog: remove Help button



commit 701851345194bdf58d3175d34254c24808ae530f
Author: Sébastien Wilmet <swilmet gnome org>
Date:   Sun Apr 5 10:49:05 2015 +0200

    EncodingsDialog: remove Help button
    
    The Help button was unhelpful, since the page about character encodings
    is not yet written. Once the page is written, we can maybe add the Help
    button back, as a GtkLinkButton.

 gedit/gedit-encodings-combo-box.c            |    7 ++-----
 gedit/gedit-encodings-dialog.c               |   10 +---------
 gedit/resources/ui/gedit-encodings-dialog.ui |   17 -----------------
 3 files changed, 3 insertions(+), 31 deletions(-)
---
diff --git a/gedit/gedit-encodings-combo-box.c b/gedit/gedit-encodings-combo-box.c
index 2d7f180..bd3b173 100644
--- a/gedit/gedit-encodings-combo-box.c
+++ b/gedit/gedit-encodings-combo-box.c
@@ -169,11 +169,8 @@ dialog_response_cb (GtkDialog              *dialog,
                     gint                    response_id,
                     GeditEncodingsComboBox *menu)
 {
-       if (response_id != GTK_RESPONSE_HELP)
-       {
-               update_menu (menu);
-               gtk_widget_destroy (GTK_WIDGET (dialog));
-       }
+       update_menu (menu);
+       gtk_widget_destroy (GTK_WIDGET (dialog));
 }
 
 static void
diff --git a/gedit/gedit-encodings-dialog.c b/gedit/gedit-encodings-dialog.c
index a180364..c1aba76 100644
--- a/gedit/gedit-encodings-dialog.c
+++ b/gedit/gedit-encodings-dialog.c
@@ -144,15 +144,7 @@ gedit_encodings_dialog_response (GtkDialog *gtk_dialog,
 {
        GeditEncodingsDialog *dialog = GEDIT_ENCODINGS_DIALOG (gtk_dialog);
 
-       if (response_id == GTK_RESPONSE_HELP)
-       {
-               gedit_app_show_help (GEDIT_APP (g_application_get_default ()),
-                                    GTK_WINDOW (dialog),
-                                    "gedit",
-                                    NULL);
-       }
-       else if (response_id == GTK_RESPONSE_CLOSE &&
-                dialog->priv->modified)
+       if (dialog->priv->modified)
        {
                GSList *enc_list;
                gchar **enc_strv;
diff --git a/gedit/resources/ui/gedit-encodings-dialog.ui b/gedit/resources/ui/gedit-encodings-dialog.ui
index 44a5259..2293908 100644
--- a/gedit/resources/ui/gedit-encodings-dialog.ui
+++ b/gedit/resources/ui/gedit-encodings-dialog.ui
@@ -46,22 +46,6 @@
             <property name="can_focus">False</property>
             <property name="layout_style">end</property>
             <child>
-              <object class="GtkButton" id="help_button">
-                <property name="label" translatable="yes">_Help</property>
-                <property name="use_action_appearance">False</property>
-                <property name="visible">True</property>
-                <property name="can_focus">True</property>
-                <property name="can_default">True</property>
-                <property name="receives_default">False</property>
-                <property name="use_underline">True</property>
-              </object>
-              <packing>
-                <property name="expand">False</property>
-                <property name="fill">True</property>
-                <property name="position">0</property>
-              </packing>
-            </child>
-            <child>
               <object class="GtkButton" id="close_button">
                 <property name="label" translatable="yes">_Close</property>
                 <property name="use_action_appearance">False</property>
@@ -291,7 +275,6 @@
       </object>
     </child>
     <action-widgets>
-      <action-widget response="-11">help_button</action-widget>
       <action-widget response="-7">close_button</action-widget>
     </action-widgets>
   </template>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]