[gnome-documents] view: Remove unused signal handler IDs



commit f2bcb605286ca15d928b6fc36fb0718225b2ec75
Author: Debarshi Ray <debarshir gnome org>
Date:   Fri Apr 10 13:13:16 2015 +0200

    view: Remove unused signal handler IDs
    
    Not only are these unused, they are also useless because we don't need
    to individually disconnect handlers for JavaScript signals. Once the
    main window is destroyed, all the connections are removed using
    disconnectAll.
    
    We only need to disconnect handlers for GObject signals.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=747506

 src/view.js |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/view.js b/src/view.js
index a73574d..1d25c4a 100644
--- a/src/view.js
+++ b/src/view.js
@@ -349,7 +349,7 @@ const ViewContainer = new Lang.Class({
         this._updateTypeForSettings();
 
         // setup selection controller => view
-        this._selectionModeId = Application.selectionController.connect('selection-mode-changed',
+        Application.selectionController.connect('selection-mode-changed',
             Lang.bind(this, this._onSelectionModeChanged));
         this._onSelectionModeChanged();
 
@@ -381,7 +381,7 @@ const ViewContainer = new Lang.Class({
 
         this._trackerController.connect('query-error',
             Lang.bind(this, this._onQueryError));
-        this._queryId = this._trackerController.connect('query-status-changed',
+        this._trackerController.connect('query-status-changed',
             Lang.bind(this, this._onQueryStatusChanged));
         // ensure the tracker controller is started
         this._trackerController.start();


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]