[gnome-builder/wip/csoriano/fixing-vim-scrolling: 1/3] ide-source-view-movements: Fix scroll off > half page
- From: Carlos Soriano Sánchez <csoriano src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-builder/wip/csoriano/fixing-vim-scrolling: 1/3] ide-source-view-movements: Fix scroll off > half page
- Date: Tue, 7 Apr 2015 17:44:09 +0000 (UTC)
commit 52931ad93bb2771638a03a5e2b438540ea30759b
Author: Carlos Soriano <csoriano gnome org>
Date: Mon Apr 6 12:40:01 2015 +0200
ide-source-view-movements: Fix scroll off > half page
If scroll off is more than half page vim converts it to half page
since it makes no sense a scroll off of more than half page.
The issue before this fix was that final position in movements were
wrong.
libide/ide-source-view-movements.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/libide/ide-source-view-movements.c b/libide/ide-source-view-movements.c
index a126d5f..433543f 100644
--- a/libide/ide-source-view-movements.c
+++ b/libide/ide-source-view-movements.c
@@ -719,11 +719,11 @@ ide_source_view_movements_move_page (Movement *mv)
buffer = gtk_text_view_get_buffer (text_view);
- scrolloff = ide_source_view_get_scroll_offset (mv->self);
line_top = gtk_text_iter_get_line (&iter_top);
line_bottom = gtk_text_iter_get_line (&iter_bottom);
half_page = MAX (1, (line_bottom - line_top) / 2);
+ scrolloff = MIN (ide_source_view_get_scroll_offset (mv->self), half_page);
switch ((int)mv->type)
{
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]