[gnome-software] plugin loader: Make sure to thaw notify signals on error path



commit b00b6aaca073f61fea0470c4ad0694f5e9a4b114
Author: Kalev Lember <kalevlember gmail com>
Date:   Tue Sep 30 11:32:18 2014 +0200

    plugin loader: Make sure to thaw notify signals on error path
    
    Otherwise we'd leave freeze count > 0 when taking an error path and
    subsequent GsApp notify:: signals would never reach the UI.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=737548

 src/gs-plugin-loader.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/src/gs-plugin-loader.c b/src/gs-plugin-loader.c
index 8664022..6414ab6 100644
--- a/src/gs-plugin-loader.c
+++ b/src/gs-plugin-loader.c
@@ -308,13 +308,13 @@ gs_plugin_loader_run_refine (GsPluginLoader *plugin_loader,
                }
        }
 
+       /* dedupe applications we already know about */
+       gs_plugin_loader_list_dedupe (plugin_loader, *list);
+out:
        /* now emit all the changed signals */
        for (l = freeze_list; l != NULL; l = l->next)
                g_object_thaw_notify (G_OBJECT (l->data));
 
-       /* dedupe applications we already know about */
-       gs_plugin_loader_list_dedupe (plugin_loader, *list);
-out:
        gs_plugin_list_free (addons_list);
        gs_plugin_list_free (related_list);
        gs_plugin_list_free (freeze_list);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]