[easytag/wip/const] WIP Sprinkle const over et_core.c



commit a5b22d34df74e88f8b27a1436904cd2b48178e41
Author: David King <amigadave amigadave com>
Date:   Mon Sep 29 23:15:37 2014 +0100

    WIP Sprinkle const over et_core.c

 src/et_core.c |  213 ++++++++++++++++++++++++++++++++++++++++-----------------
 src/et_core.h |   96 +++++++++++++-------------
 2 files changed, 197 insertions(+), 112 deletions(-)
---
diff --git a/src/et_core.c b/src/et_core.c
index 88fa248..680d406 100644
--- a/src/et_core.c
+++ b/src/et_core.c
@@ -129,7 +129,6 @@ GdkRGBA RED = {1.0, 0.0, 0.0, 1.0 };
  **************/
 
 //gboolean ET_File_Is_Supported (gchar *filename);
-static gchar *ET_Get_File_Extension (const gchar *filename);
 static const ET_File_Description *ET_Get_File_Description (const gchar *filename);
 static const ET_File_Description *ET_Get_File_Description_From_Extension (const gchar *extension);
 
@@ -160,15 +159,15 @@ static gboolean ET_Remove_File_From_Artist_Album_List (ET_File *ETFile);
 static void ET_Display_Filename_To_UI (ET_File *ETFile);
 static EtFileHeaderFields * ET_Display_File_Info_To_UI (ET_File *ETFile);
 
-static gboolean ET_Save_File_Name_From_UI (ET_File *ETFile,
+static gboolean ET_Save_File_Name_From_UI (const ET_File *ETFile,
                                            File_Name *FileName);
 static gboolean ET_Save_File_Name_Internal (ET_File *ETFile, File_Name *FileName);
 static gboolean ET_Save_File_Tag_Internal (ET_File *ETFile, File_Tag *FileTag);
 
 static void ET_Mark_File_Tag_As_Saved (ET_File *ETFile);
 
-static gboolean ET_Detect_Changes_Of_File_Name (File_Name *FileName1,
-                                                File_Name *FileName2);
+static gboolean ET_Detect_Changes_Of_File_Name (const File_Name *FileName1,
+                                                const File_Name *FileName2);
 static gboolean ET_Add_File_Name_To_List (ET_File *ETFile,
                                           File_Name *FileName);
 static gboolean ET_Add_File_Tag_To_List (ET_File *ETFile, File_Tag  *FileTag);
@@ -186,9 +185,9 @@ static gint ET_Comp_Func_Sort_Artist_Item_By_Ascending_Artist (GList *AlbumList1
                                                                GList *AlbumList2);
 static gint ET_Comp_Func_Sort_Album_Item_By_Ascending_Album (GList *etfilelist1,
                                                              GList *etfilelist2);
-static gint ET_Comp_Func_Sort_Etfile_Item_By_Ascending_Filename (ET_File *ETFile1,
-                                                                 ET_File *ETFile2);
-static gchar *ET_File_Name_Format_Extension (ET_File *ETFile);
+static gint ET_Comp_Func_Sort_Etfile_Item_By_Ascending_Filename (const ET_File *ETFile1,
+                                                                 const ET_File *ETFile2);
+static gchar *ET_File_Name_Format_Extension (const ET_File *ETFile);
 
 static void set_sort_order_for_column_id (gint column_id,
                                           GtkTreeViewColumn *column,
@@ -202,7 +201,7 @@ static void set_sort_order_for_column_id (gint column_id,
 /*
  * Returns the extension of the file
  */
-static gchar *
+static const gchar *
 ET_Get_File_Extension (const gchar *filename)
 {
     if (filename)
@@ -1226,10 +1225,12 @@ ET_Sort_Displayed_File_List_And_Update_UI (EtSortMode Sorting_Type)
 /*
  * Comparison function for sorting by ascending filename.
  */
-gint ET_Comp_Func_Sort_File_By_Ascending_Filename (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Ascending_Filename (const ET_File *ETFile1,
+                                              const ET_File *ETFile2)
 {
-    gchar *file1_ck   = ((File_Name *)((GList *)ETFile1->FileNameCur)->data)->value_ck;
-    gchar *file2_ck   = ((File_Name *)((GList *)ETFile2->FileNameCur)->data)->value_ck;
+    const gchar *file1_ck = ((File_Name *)((GList *)ETFile1->FileNameCur)->data)->value_ck;
+    const gchar *file2_ck = ((File_Name *)((GList *)ETFile2->FileNameCur)->data)->value_ck;
     // !!!! : Must be the same rules as "Cddb_Track_List_Sort_Func" to be
     // able to sort in the same order files in cddb and in the file list.
     return g_settings_get_boolean (MainSettings,
@@ -1240,7 +1241,9 @@ gint ET_Comp_Func_Sort_File_By_Ascending_Filename (ET_File *ETFile1, ET_File *ET
 /*
  * Comparison function for sorting by descending filename.
  */
-gint ET_Comp_Func_Sort_File_By_Descending_Filename (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Descending_Filename (const ET_File *ETFile1,
+                                               const ET_File *ETFile2)
 {
     return ET_Comp_Func_Sort_File_By_Ascending_Filename(ETFile2,ETFile1);
 }
@@ -1250,8 +1253,8 @@ gint ET_Comp_Func_Sort_File_By_Descending_Filename (ET_File *ETFile1, ET_File *E
  * Comparison function for sorting by ascending disc number.
  */
 gint
-et_comp_func_sort_file_by_ascending_disc_number (ET_File *ETFile1,
-                                                 ET_File *ETFile2)
+et_comp_func_sort_file_by_ascending_disc_number (const ET_File *ETFile1,
+                                                 const ET_File *ETFile2)
 {
     gint track1, track2;
 
@@ -1289,8 +1292,8 @@ et_comp_func_sort_file_by_ascending_disc_number (ET_File *ETFile1,
  * Comparison function for sorting by descending disc number.
  */
 gint
-et_comp_func_sort_file_by_descending_disc_number (ET_File *ETFile1,
-                                                  ET_File *ETFile2)
+et_comp_func_sort_file_by_descending_disc_number (const ET_File *ETFile1,
+                                                  const ET_File *ETFile2)
 {
     return et_comp_func_sort_file_by_ascending_disc_number (ETFile2, ETFile1);
 }
@@ -1299,7 +1302,9 @@ et_comp_func_sort_file_by_descending_disc_number (ET_File *ETFile1,
 /*
  * Comparison function for sorting by ascending track number.
  */
-gint ET_Comp_Func_Sort_File_By_Ascending_Track_Number (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Ascending_Track_Number (const ET_File *ETFile1,
+                                                  const ET_File *ETFile2)
 {
     gint track1, track2;
 
@@ -1324,7 +1329,9 @@ gint ET_Comp_Func_Sort_File_By_Ascending_Track_Number (ET_File *ETFile1, ET_File
 /*
  * Comparison function for sorting by descending track number.
  */
-gint ET_Comp_Func_Sort_File_By_Descending_Track_Number (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Descending_Track_Number (const ET_File *ETFile1,
+                                                   const ET_File *ETFile2)
 {
     return ET_Comp_Func_Sort_File_By_Ascending_Track_Number(ETFile2,ETFile1);
 }
@@ -1333,7 +1340,9 @@ gint ET_Comp_Func_Sort_File_By_Descending_Track_Number (ET_File *ETFile1, ET_Fil
 /*
  * Comparison function for sorting by ascending creation date.
  */
-gint ET_Comp_Func_Sort_File_By_Ascending_Creation_Date (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Ascending_Creation_Date (const ET_File *ETFile1,
+                                                   const ET_File *ETFile2)
 {
     GFile *file;
     GFileInfo *info;
@@ -1380,7 +1389,9 @@ gint ET_Comp_Func_Sort_File_By_Ascending_Creation_Date (ET_File *ETFile1, ET_Fil
 /*
  * Comparison function for sorting by descending creation date.
  */
-gint ET_Comp_Func_Sort_File_By_Descending_Creation_Date (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Descending_Creation_Date (const ET_File *ETFile1,
+                                                    const ET_File *ETFile2)
 {
     return ET_Comp_Func_Sort_File_By_Ascending_Creation_Date(ETFile2,ETFile1);
 }
@@ -1389,7 +1400,9 @@ gint ET_Comp_Func_Sort_File_By_Descending_Creation_Date (ET_File *ETFile1, ET_Fi
 /*
  * Comparison function for sorting by ascending title.
  */
-gint ET_Comp_Func_Sort_File_By_Ascending_Title (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Ascending_Title (const ET_File *ETFile1,
+                                           const ET_File *ETFile2)
 {
    // Compare pointers just in case they are the same (e.g. both are NULL)
    if ((ETFile1->FileTag->data == ETFile2->FileTag->data)
@@ -1423,7 +1436,9 @@ gint ET_Comp_Func_Sort_File_By_Ascending_Title (ET_File *ETFile1, ET_File *ETFil
 /*
  * Comparison function for sorting by descending title.
  */
-gint ET_Comp_Func_Sort_File_By_Descending_Title (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Descending_Title (const ET_File *ETFile1,
+                                            const ET_File *ETFile2)
 {
     return ET_Comp_Func_Sort_File_By_Ascending_Title(ETFile2,ETFile1);
 }
@@ -1432,7 +1447,9 @@ gint ET_Comp_Func_Sort_File_By_Descending_Title (ET_File *ETFile1, ET_File *ETFi
 /*
  * Comparison function for sorting by ascending artist.
  */
-gint ET_Comp_Func_Sort_File_By_Ascending_Artist (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Ascending_Artist (const ET_File *ETFile1,
+                                            const ET_File *ETFile2)
 {
    // Compare pointers just in case they are the same (e.g. both are NULL)
    if ((ETFile1->FileTag->data == ETFile2->FileTag->data)
@@ -1466,7 +1483,9 @@ gint ET_Comp_Func_Sort_File_By_Ascending_Artist (ET_File *ETFile1, ET_File *ETFi
 /*
  * Comparison function for sorting by descending artist.
  */
-gint ET_Comp_Func_Sort_File_By_Descending_Artist (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Descending_Artist (const ET_File *ETFile1,
+                                             const ET_File *ETFile2)
 {
     return ET_Comp_Func_Sort_File_By_Ascending_Artist(ETFile2,ETFile1);
 }
@@ -1474,7 +1493,9 @@ gint ET_Comp_Func_Sort_File_By_Descending_Artist (ET_File *ETFile1, ET_File *ETF
 /*
  * Comparison function for sorting by ascending album artist.
  */
-gint ET_Comp_Func_Sort_File_By_Ascending_Album_Artist (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Ascending_Album_Artist (const ET_File *ETFile1,
+                                                  const ET_File *ETFile2)
 {
    // Compare pointers just in case they are the same (e.g. both are NULL)
    if ((ETFile1->FileTag->data == ETFile2->FileTag->data)
@@ -1508,7 +1529,9 @@ gint ET_Comp_Func_Sort_File_By_Ascending_Album_Artist (ET_File *ETFile1, ET_File
 /*
  * Comparison function for sorting by descending album artist.
  */
-gint ET_Comp_Func_Sort_File_By_Descending_Album_Artist (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Descending_Album_Artist (const ET_File *ETFile1,
+                                                   const ET_File *ETFile2)
 {
     return ET_Comp_Func_Sort_File_By_Ascending_Album_Artist(ETFile2,ETFile1);
 }
@@ -1516,7 +1539,9 @@ gint ET_Comp_Func_Sort_File_By_Descending_Album_Artist (ET_File *ETFile1, ET_Fil
 /*
  * Comparison function for sorting by ascending album.
  */
-gint ET_Comp_Func_Sort_File_By_Ascending_Album (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Ascending_Album (const ET_File *ETFile1,
+                                           const ET_File *ETFile2)
 {
    // Compare pointers just in case they are the same (e.g. both are NULL)
    if ((ETFile1->FileTag->data == ETFile2->FileTag->data)
@@ -1550,7 +1575,9 @@ gint ET_Comp_Func_Sort_File_By_Ascending_Album (ET_File *ETFile1, ET_File *ETFil
 /*
  * Comparison function for sorting by descending album.
  */
-gint ET_Comp_Func_Sort_File_By_Descending_Album (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Descending_Album (const ET_File *ETFile1,
+                                            const ET_File *ETFile2)
 {
     return ET_Comp_Func_Sort_File_By_Ascending_Album(ETFile2,ETFile1);
 }
@@ -1559,7 +1586,9 @@ gint ET_Comp_Func_Sort_File_By_Descending_Album (ET_File *ETFile1, ET_File *ETFi
 /*
  * Comparison function for sorting by ascending year.
  */
-gint ET_Comp_Func_Sort_File_By_Ascending_Year (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Ascending_Year (const ET_File *ETFile1,
+                                          const ET_File *ETFile2)
 {
     gint year1, year2;
 
@@ -1584,7 +1613,9 @@ gint ET_Comp_Func_Sort_File_By_Ascending_Year (ET_File *ETFile1, ET_File *ETFile
 /*
  * Comparison function for sorting by descending year.
  */
-gint ET_Comp_Func_Sort_File_By_Descending_Year (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Descending_Year (const ET_File *ETFile1,
+                                           const ET_File *ETFile2)
 {
     return ET_Comp_Func_Sort_File_By_Ascending_Year(ETFile2,ETFile1);
 }
@@ -1593,7 +1624,9 @@ gint ET_Comp_Func_Sort_File_By_Descending_Year (ET_File *ETFile1, ET_File *ETFil
 /*
  * Comparison function for sorting by ascending genre.
  */
-gint ET_Comp_Func_Sort_File_By_Ascending_Genre (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Ascending_Genre (const ET_File *ETFile1,
+                                           const ET_File *ETFile2)
 {
    // Compare pointers just in case they are the same (e.g. both are NULL)
    if ((ETFile1->FileTag->data == ETFile2->FileTag->data)
@@ -1625,7 +1658,9 @@ gint ET_Comp_Func_Sort_File_By_Ascending_Genre (ET_File *ETFile1, ET_File *ETFil
 /*
  * Comparison function for sorting by descending genre.
  */
-gint ET_Comp_Func_Sort_File_By_Descending_Genre (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Descending_Genre (const ET_File *ETFile1,
+                                            const ET_File *ETFile2)
 {
     return ET_Comp_Func_Sort_File_By_Ascending_Genre(ETFile2,ETFile1);
 }
@@ -1634,7 +1669,9 @@ gint ET_Comp_Func_Sort_File_By_Descending_Genre (ET_File *ETFile1, ET_File *ETFi
 /*
  * Comparison function for sorting by ascending comment.
  */
-gint ET_Comp_Func_Sort_File_By_Ascending_Comment (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Ascending_Comment (const ET_File *ETFile1,
+                                             const ET_File *ETFile2)
 {
    // Compare pointers just in case they are the same (e.g. both are NULL)
    if ((ETFile1->FileTag->data == ETFile2->FileTag->data)
@@ -1668,7 +1705,9 @@ gint ET_Comp_Func_Sort_File_By_Ascending_Comment (ET_File *ETFile1, ET_File *ETF
 /*
  * Comparison function for sorting by descending comment.
  */
-gint ET_Comp_Func_Sort_File_By_Descending_Comment (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Descending_Comment (const ET_File *ETFile1,
+                                              const ET_File *ETFile2)
 {
     return ET_Comp_Func_Sort_File_By_Ascending_Comment(ETFile2,ETFile1);
 }
@@ -1677,7 +1716,9 @@ gint ET_Comp_Func_Sort_File_By_Descending_Comment (ET_File *ETFile1, ET_File *ET
 /*
  * Comparison function for sorting by ascending composer.
  */
-gint ET_Comp_Func_Sort_File_By_Ascending_Composer (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Ascending_Composer (const ET_File *ETFile1,
+                                              const ET_File *ETFile2)
 {
    // Compare pointers just in case they are the same (e.g. both are NULL)
    if ((ETFile1->FileTag->data == ETFile2->FileTag->data)
@@ -1711,7 +1752,9 @@ gint ET_Comp_Func_Sort_File_By_Ascending_Composer (ET_File *ETFile1, ET_File *ET
 /*
  * Comparison function for sorting by descending composer.
  */
-gint ET_Comp_Func_Sort_File_By_Descending_Composer (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Descending_Composer (const ET_File *ETFile1,
+                                               const ET_File *ETFile2)
 {
     return ET_Comp_Func_Sort_File_By_Ascending_Composer(ETFile2,ETFile1);
 }
@@ -1720,7 +1763,9 @@ gint ET_Comp_Func_Sort_File_By_Descending_Composer (ET_File *ETFile1, ET_File *E
 /*
  * Comparison function for sorting by ascending original artist.
  */
-gint ET_Comp_Func_Sort_File_By_Ascending_Orig_Artist (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Ascending_Orig_Artist (const ET_File *ETFile1,
+                                                 const ET_File *ETFile2)
 {
    // Compare pointers just in case they are the same (e.g. both are NULL)
    if ((ETFile1->FileTag->data == ETFile2->FileTag->data)
@@ -1754,7 +1799,9 @@ gint ET_Comp_Func_Sort_File_By_Ascending_Orig_Artist (ET_File *ETFile1, ET_File
 /*
  * Comparison function for sorting by descending original artist.
  */
-gint ET_Comp_Func_Sort_File_By_Descending_Orig_Artist (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Descending_Orig_Artist (const ET_File *ETFile1,
+                                                  const ET_File *ETFile2)
 {
     return ET_Comp_Func_Sort_File_By_Ascending_Orig_Artist(ETFile2,ETFile1);
 }
@@ -1763,7 +1810,9 @@ gint ET_Comp_Func_Sort_File_By_Descending_Orig_Artist (ET_File *ETFile1, ET_File
 /*
  * Comparison function for sorting by ascending copyright.
  */
-gint ET_Comp_Func_Sort_File_By_Ascending_Copyright (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Ascending_Copyright (const ET_File *ETFile1,
+                                               const ET_File *ETFile2)
 {
    // Compare pointers just in case they are the same (e.g. both are NULL)
    if ((ETFile1->FileTag->data == ETFile2->FileTag->data)
@@ -1797,7 +1846,9 @@ gint ET_Comp_Func_Sort_File_By_Ascending_Copyright (ET_File *ETFile1, ET_File *E
 /*
  * Comparison function for sorting by descending copyright.
  */
-gint ET_Comp_Func_Sort_File_By_Descending_Copyright (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Descending_Copyright (const ET_File *ETFile1,
+                                                const ET_File *ETFile2)
 {
     return ET_Comp_Func_Sort_File_By_Ascending_Copyright(ETFile2,ETFile1);
 }
@@ -1806,7 +1857,9 @@ gint ET_Comp_Func_Sort_File_By_Descending_Copyright (ET_File *ETFile1, ET_File *
 /*
  * Comparison function for sorting by ascending URL.
  */
-gint ET_Comp_Func_Sort_File_By_Ascending_Url (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Ascending_Url (const ET_File *ETFile1,
+                                         const ET_File *ETFile2)
 {
    // Compare pointers just in case they are the same (e.g. both are NULL)
    if ((ETFile1->FileTag->data == ETFile2->FileTag->data)
@@ -1840,7 +1893,9 @@ gint ET_Comp_Func_Sort_File_By_Ascending_Url (ET_File *ETFile1, ET_File *ETFile2
 /*
  * Comparison function for sorting by descending URL.
  */
-gint ET_Comp_Func_Sort_File_By_Descending_Url (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Descending_Url (const ET_File *ETFile1,
+                                          const ET_File *ETFile2)
 {
     return ET_Comp_Func_Sort_File_By_Ascending_Url(ETFile2,ETFile1);
 }
@@ -1849,7 +1904,9 @@ gint ET_Comp_Func_Sort_File_By_Descending_Url (ET_File *ETFile1, ET_File *ETFile
 /*
  * Comparison function for sorting by ascending encoded by.
  */
-gint ET_Comp_Func_Sort_File_By_Ascending_Encoded_By (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Ascending_Encoded_By (const ET_File *ETFile1,
+                                                const ET_File *ETFile2)
 {
    // Compare pointers just in case they are the same (e.g. both are NULL)
    if ((ETFile1->FileTag->data == ETFile2->FileTag->data)
@@ -1883,7 +1940,9 @@ gint ET_Comp_Func_Sort_File_By_Ascending_Encoded_By (ET_File *ETFile1, ET_File *
 /*
  * Comparison function for sorting by descendingencoded by.
  */
-gint ET_Comp_Func_Sort_File_By_Descending_Encoded_By (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Descending_Encoded_By (const ET_File *ETFile1,
+                                                 const ET_File *ETFile2)
 {
     return ET_Comp_Func_Sort_File_By_Ascending_Encoded_By(ETFile2,ETFile1);
 }
@@ -1892,7 +1951,9 @@ gint ET_Comp_Func_Sort_File_By_Descending_Encoded_By (ET_File *ETFile1, ET_File
 /*
  * Comparison function for sorting by ascending file type (mp3, ogg, ...).
  */
-gint ET_Comp_Func_Sort_File_By_Ascending_File_Type (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Ascending_File_Type (const ET_File *ETFile1,
+                                               const ET_File *ETFile2)
 {
     if ( !ETFile1->ETFileDescription ) return -1;
     if ( !ETFile2->ETFileDescription ) return 1;
@@ -1908,7 +1969,9 @@ gint ET_Comp_Func_Sort_File_By_Ascending_File_Type (ET_File *ETFile1, ET_File *E
 /*
  * Comparison function for sorting by descending file type (mp3, ogg, ...).
  */
-gint ET_Comp_Func_Sort_File_By_Descending_File_Type (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Descending_File_Type (const ET_File *ETFile1,
+                                                const ET_File *ETFile2)
 {
     return ET_Comp_Func_Sort_File_By_Ascending_File_Type(ETFile2,ETFile1);
 }
@@ -1917,7 +1980,9 @@ gint ET_Comp_Func_Sort_File_By_Descending_File_Type (ET_File *ETFile1, ET_File *
 /*
  * Comparison function for sorting by ascending file size.
  */
-gint ET_Comp_Func_Sort_File_By_Ascending_File_Size (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Ascending_File_Size (const ET_File *ETFile1,
+                                               const ET_File *ETFile2)
 {
     if ( !ETFile1->ETFileInfo ) return -1;
     if ( !ETFile2->ETFileInfo ) return 1;
@@ -1933,7 +1998,9 @@ gint ET_Comp_Func_Sort_File_By_Ascending_File_Size (ET_File *ETFile1, ET_File *E
 /*
  * Comparison function for sorting by descending file size.
  */
-gint ET_Comp_Func_Sort_File_By_Descending_File_Size (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Descending_File_Size (const ET_File *ETFile1,
+                                                const ET_File *ETFile2)
 {
     return ET_Comp_Func_Sort_File_By_Ascending_File_Size(ETFile2,ETFile1);
 }
@@ -1942,7 +2009,9 @@ gint ET_Comp_Func_Sort_File_By_Descending_File_Size (ET_File *ETFile1, ET_File *
 /*
  * Comparison function for sorting by ascending file duration.
  */
-gint ET_Comp_Func_Sort_File_By_Ascending_File_Duration (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Ascending_File_Duration (const ET_File *ETFile1,
+                                                   const ET_File *ETFile2)
 {
     if ( !ETFile1->ETFileInfo ) return -1;
     if ( !ETFile2->ETFileInfo ) return 1;
@@ -1958,7 +2027,9 @@ gint ET_Comp_Func_Sort_File_By_Ascending_File_Duration (ET_File *ETFile1, ET_Fil
 /*
  * Comparison function for sorting by descending file duration.
  */
-gint ET_Comp_Func_Sort_File_By_Descending_File_Duration (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Descending_File_Duration (const ET_File *ETFile1,
+                                                    const ET_File *ETFile2)
 {
     return ET_Comp_Func_Sort_File_By_Ascending_File_Duration(ETFile2,ETFile1);
 }
@@ -1967,7 +2038,9 @@ gint ET_Comp_Func_Sort_File_By_Descending_File_Duration (ET_File *ETFile1, ET_Fi
 /*
  * Comparison function for sorting by ascending file bitrate.
  */
-gint ET_Comp_Func_Sort_File_By_Ascending_File_Bitrate (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Ascending_File_Bitrate (const ET_File *ETFile1,
+                                                  const ET_File *ETFile2)
 {
     if ( !ETFile1->ETFileInfo ) return -1;
     if ( !ETFile2->ETFileInfo ) return 1;
@@ -1983,7 +2056,9 @@ gint ET_Comp_Func_Sort_File_By_Ascending_File_Bitrate (ET_File *ETFile1, ET_File
 /*
  * Comparison function for sorting by descending file bitrate.
  */
-gint ET_Comp_Func_Sort_File_By_Descending_File_Bitrate (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Descending_File_Bitrate (const ET_File *ETFile1,
+                                                   const ET_File *ETFile2)
 {
     return ET_Comp_Func_Sort_File_By_Ascending_File_Bitrate(ETFile2,ETFile1);
 }
@@ -1992,7 +2067,9 @@ gint ET_Comp_Func_Sort_File_By_Descending_File_Bitrate (ET_File *ETFile1, ET_Fil
 /*
  * Comparison function for sorting by ascending file samplerate.
  */
-gint ET_Comp_Func_Sort_File_By_Ascending_File_Samplerate (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Ascending_File_Samplerate (const ET_File *ETFile1,
+                                                     const ET_File *ETFile2)
 {
     if ( !ETFile1->ETFileInfo ) return -1;
     if ( !ETFile2->ETFileInfo ) return 1;
@@ -2008,7 +2085,9 @@ gint ET_Comp_Func_Sort_File_By_Ascending_File_Samplerate (ET_File *ETFile1, ET_F
 /*
  * Comparison function for sorting by descending file samplerate.
  */
-gint ET_Comp_Func_Sort_File_By_Descending_File_Samplerate (ET_File *ETFile1, ET_File *ETFile2)
+gint
+ET_Comp_Func_Sort_File_By_Descending_File_Samplerate (const ET_File *ETFile1,
+                                                      const ET_File *ETFile2)
 {
     return ET_Comp_Func_Sort_File_By_Ascending_File_Samplerate(ETFile2,ETFile1);
 }
@@ -2022,7 +2101,8 @@ static gint ET_Comp_Func_Sort_Artist_Item_By_Ascending_Artist (GList *AlbumList1
 {
     GList   *etfilelist1 = NULL,    *etfilelist2 = NULL;
     ET_File *etfile1 = NULL,        *etfile2 = NULL;
-    gchar   *etfile1_artist, *etfile2_artist;
+    const gchar *etfile1_artist;
+    const gchar *etfile2_artist;
 
     if (!AlbumList1
     || !(etfilelist1    = (GList *)AlbumList1->data)
@@ -2050,7 +2130,8 @@ ET_Comp_Func_Sort_Album_Item_By_Ascending_Album (GList *etfilelist1,
                                                  GList *etfilelist2)
 {
     ET_File *etfile1,       *etfile2;
-    gchar   *etfile1_album, *etfile2_album;
+    const gchar *etfile1_album;
+    const gchar *etfile2_album;
 
     if (!etfilelist1
     || !(etfile1        = (ET_File *)etfilelist1->data)
@@ -2073,8 +2154,8 @@ ET_Comp_Func_Sort_Album_Item_By_Ascending_Album (GList *etfilelist1,
  * FIX ME : should use the default sorting!
  */
 static gint
-ET_Comp_Func_Sort_Etfile_Item_By_Ascending_Filename (ET_File *ETFile1,
-                                                     ET_File *ETFile2)
+ET_Comp_Func_Sort_Etfile_Item_By_Ascending_Filename (const ET_File *ETFile1,
+                                                     const ET_File *ETFile2)
 {
 
     if (!ETFile1) return -1;
@@ -3065,7 +3146,7 @@ void ET_Save_File_Data_From_UI (ET_File *ETFile)
  *        encoding, not UTF-8 (it preserves file system encoding of parent directories).
  */
 static gboolean
-ET_Save_File_Name_From_UI (ET_File *ETFile, File_Name *FileName)
+ET_Save_File_Name_From_UI (const ET_File *ETFile, File_Name *FileName)
 {
     gchar *filename_new = NULL;
     gchar *dirname = NULL;
@@ -3675,7 +3756,8 @@ gboolean ET_Manage_Changes_Of_File_Data (ET_File *ETFile, File_Name *FileName, F
  *  - else returns FALSE
  */
 static gboolean
-ET_Detect_Changes_Of_File_Name (File_Name *FileName1, File_Name *FileName2)
+ET_Detect_Changes_Of_File_Name (const File_Name *FileName1,
+                                const File_Name *FileName2)
 {
     const gchar *filename1_ck;
     const gchar *filename2_ck;
@@ -3986,7 +4068,8 @@ gboolean ET_Undo_File_Data (ET_File *ETFile)
 /*
  * Returns TRUE if file contains undo data (filename or tag)
  */
-gboolean ET_File_Data_Has_Undo_Data (ET_File *ETFile)
+gboolean
+ET_File_Data_Has_Undo_Data (const ET_File *ETFile)
 {
     gboolean has_filename_undo_data = FALSE;
     gboolean has_filetag_undo_data  = FALSE;
@@ -4046,7 +4129,8 @@ gboolean ET_Redo_File_Data (ET_File *ETFile)
 /*
  * Returns TRUE if file contains redo data (filename or tag)
  */
-gboolean ET_File_Data_Has_Redo_Data (ET_File *ETFile)
+gboolean
+ET_File_Data_Has_Redo_Data (const ET_File *ETFile)
 {
     gboolean has_filename_redo_data = FALSE;
     gboolean has_filetag_redo_data  = FALSE;
@@ -4140,7 +4224,8 @@ gboolean ET_History_File_List_Has_Redo_Data (void)
  * Returns TRUE if the file has been saved.
  * Returns FALSE if some changes haven't been saved.
  */
-gboolean ET_Check_If_File_Is_Saved (ET_File *ETFile)
+gboolean
+ET_Check_If_File_Is_Saved (const ET_File *ETFile)
 {
     File_Tag  *FileTag     = NULL;
     File_Name *FileNameNew = NULL;
@@ -4376,7 +4461,7 @@ gchar *ET_File_Name_Generate (ET_File *ETFile, gchar *new_file_name_utf8)
 
 /* Convert filename extension (lower/upper/no change). */
 static gchar *
-ET_File_Name_Format_Extension (ET_File *ETFile)
+ET_File_Name_Format_Extension (const ET_File *ETFile)
 {
     EtFilenameExtensionMode mode;
 
diff --git a/src/et_core.h b/src/et_core.h
index 5338091..fa420e0 100644
--- a/src/et_core.h
+++ b/src/et_core.h
@@ -288,7 +288,7 @@ gboolean ET_Remove_File_From_File_List   (ET_File *ETFile);
 gboolean ET_Create_Artist_Album_File_List      (void);
 gboolean ET_Remove_File_From_File_List         (ET_File *ETFile);
 
-gboolean ET_Check_If_File_Is_Saved       (ET_File *ETFile);
+gboolean ET_Check_If_File_Is_Saved (const ET_File *ETFile);
 gboolean ET_Check_If_All_Files_Are_Saved (void);
 
 ET_File      *ET_File_Item_New       (void);
@@ -317,8 +317,8 @@ gboolean ET_Save_File_Tag_To_HD (ET_File *ETFile, GError **error);
 
 gboolean ET_Undo_File_Data          (ET_File *ETFile);
 gboolean ET_Redo_File_Data          (ET_File *ETFile);
-gboolean ET_File_Data_Has_Undo_Data (ET_File *ETFile);
-gboolean ET_File_Data_Has_Redo_Data (ET_File *ETFile);
+gboolean ET_File_Data_Has_Undo_Data (const ET_File *ETFile);
+gboolean ET_File_Data_Has_Redo_Data (const ET_File *ETFile);
 
 ET_File *ET_Undo_History_File_Data          (void);
 ET_File *ET_Redo_History_File_Data          (void);
@@ -336,51 +336,51 @@ gboolean ET_Detect_Changes_Of_File_Tag (const File_Tag *FileTag1, const File_Tag
 
 GList *ET_Sort_File_List (GList *ETFileList, EtSortMode Sorting_Type);
 void ET_Sort_Displayed_File_List_And_Update_UI (EtSortMode Sorting_Type);
-gint ET_Comp_Func_Sort_File_By_Ascending_Filename         (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Descending_Filename        (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Ascending_Creation_Date    (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Descending_Creation_Date   (ET_File *ETFile1, ET_File *ETFile2);
-gint et_comp_func_sort_file_by_ascending_disc_number (ET_File *ETFile1,
-                                                      ET_File *ETFile2);
-gint et_comp_func_sort_file_by_descending_disc_number (ET_File *ETFile1,
-                                                       ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Ascending_Track_Number     (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Descending_Track_Number    (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Ascending_Title            (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Descending_Title           (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Ascending_Artist           (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Descending_Artist          (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Ascending_Album_Artist     (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Descending_Album_Artist    (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Ascending_Album            (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Descending_Album           (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Ascending_Year             (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Descending_Year            (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Ascending_Genre            (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Descending_Genre           (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Ascending_Comment          (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Descending_Comment         (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Ascending_Composer         (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Descending_Composer        (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Ascending_Orig_Artist      (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Descending_Orig_Artist     (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Ascending_Copyright        (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Descending_Copyright       (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Ascending_Url              (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Descending_Url             (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Ascending_Encoded_By       (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Descending_Encoded_By      (ET_File *ETFile1, ET_File *ETFile2);
-
-gint ET_Comp_Func_Sort_File_By_Ascending_File_Type        (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Descending_File_Type       (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Ascending_File_Size        (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Descending_File_Size       (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Ascending_File_Duration    (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Descending_File_Duration   (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Ascending_File_Bitrate     (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Descending_File_Bitrate    (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Ascending_File_Samplerate  (ET_File *ETFile1, ET_File *ETFile2);
-gint ET_Comp_Func_Sort_File_By_Descending_File_Samplerate (ET_File *ETFile1, ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Ascending_Filename (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Descending_Filename (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Ascending_Creation_Date (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Descending_Creation_Date (const ET_File *ETFile1, const ET_File *ETFile2);
+gint et_comp_func_sort_file_by_ascending_disc_number (const ET_File *ETFile1,
+                                                      const ET_File *ETFile2);
+gint et_comp_func_sort_file_by_descending_disc_number (const ET_File *ETFile1,
+                                                       const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Ascending_Track_Number (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Descending_Track_Number (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Ascending_Title (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Descending_Title (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Ascending_Artist (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Descending_Artist (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Ascending_Album_Artist (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Descending_Album_Artist (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Ascending_Album (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Descending_Album (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Ascending_Year (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Descending_Year (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Ascending_Genre (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Descending_Genre (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Ascending_Comment (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Descending_Comment (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Ascending_Composer (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Descending_Composer (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Ascending_Orig_Artist (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Descending_Orig_Artist (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Ascending_Copyright (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Descending_Copyright (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Ascending_Url (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Descending_Url (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Ascending_Encoded_By (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Descending_Encoded_By (const ET_File *ETFile1, const ET_File *ETFile2);
+
+gint ET_Comp_Func_Sort_File_By_Ascending_File_Type (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Descending_File_Type (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Ascending_File_Size (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Descending_File_Size (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Ascending_File_Duration (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Descending_File_Duration (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Ascending_File_Bitrate (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Descending_File_Bitrate (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Ascending_File_Samplerate (const ET_File *ETFile1, const ET_File *ETFile2);
+gint ET_Comp_Func_Sort_File_By_Descending_File_Samplerate (const ET_File *ETFile1, const ET_File *ETFile2);
 
 G_END_DECLS
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]