[gnome-photos] preview-view: Disable the sliding transition



commit 459b4e370e8a1fb5a5255dcd5835fc2583da7aec
Author: Debarshi Ray <debarshir gnome org>
Date:   Wed Sep 24 11:40:09 2014 +0200

    preview-view: Disable the sliding transition
    
    Sometimes we hit a slow path in GEGL when rendering which makes the
    transition jittery and look broken. Let's disable it till we have a
    solution to make it smoother.
    
    Fixes: https://bugzilla.gnome.org/726505

 src/photos-preview-view.c |   26 ++------------------------
 1 files changed, 2 insertions(+), 24 deletions(-)
---
diff --git a/src/photos-preview-view.c b/src/photos-preview-view.c
index 5ff9330..ca38c54 100644
--- a/src/photos-preview-view.c
+++ b/src/photos-preview-view.c
@@ -105,8 +105,8 @@ static void
 photos_preview_view_nav_buttons_activated (PhotosPreviewView *self, PhotosPreviewAction action)
 {
   PhotosPreviewViewPrivate *priv = self->priv;
-  GtkStackTransitionType transition;
   GtkWidget *current_view;
+  GtkWidget *new_view;
   GtkWidget *next_view;
   gint position;
 
@@ -117,12 +117,10 @@ photos_preview_view_nav_buttons_activated (PhotosPreviewView *self, PhotosPrevie
     {
     case PHOTOS_PREVIEW_ACTION_NEXT:
       position = 0;
-      transition = GTK_STACK_TRANSITION_TYPE_SLIDE_LEFT_RIGHT;
       break;
 
     case PHOTOS_PREVIEW_ACTION_PREVIOUS:
       position = -1;
-      transition = GTK_STACK_TRANSITION_TYPE_SLIDE_LEFT_RIGHT;
       break;
 
     default:
@@ -133,25 +131,10 @@ photos_preview_view_nav_buttons_activated (PhotosPreviewView *self, PhotosPrevie
   current_view = gtk_stack_get_visible_child (GTK_STACK (priv->stack));
   gtk_container_child_set (GTK_CONTAINER (priv->stack), current_view, "position", position, NULL);
 
-  gtk_stack_set_transition_type (GTK_STACK (priv->stack), transition);
-
   next_view = photos_preview_view_get_invisible_view (self);
   gtk_stack_set_visible_child (GTK_STACK (priv->stack), next_view);
-}
-
-
-static void
-photos_preview_view_notify_transition_running (PhotosPreviewView *self)
-{
-  PhotosPreviewViewPrivate *priv = self->priv;
-  GtkWidget *old_view;
-  GtkWidget *new_view;
 
-  if (gtk_stack_get_transition_running (GTK_STACK (priv->stack)))
-    return;
-
-  old_view = photos_preview_view_get_invisible_view (self);
-  gtk_container_remove (GTK_CONTAINER (priv->stack), old_view);
+  gtk_container_remove (GTK_CONTAINER (priv->stack), current_view);
 
   new_view = photos_preview_view_create_view (self);
   gtk_container_add (GTK_CONTAINER (priv->stack), new_view);
@@ -322,11 +305,6 @@ photos_preview_view_init (PhotosPreviewView *self)
   gtk_style_context_add_class (context, "documents-scrolledwin");
 
   priv->stack = gtk_stack_new ();
-  gtk_stack_set_transition_duration (GTK_STACK (priv->stack), 400);
-  g_signal_connect_swapped (priv->stack,
-                            "notify::transition-running",
-                            G_CALLBACK (photos_preview_view_notify_transition_running),
-                            self);
 
   view = photos_preview_view_create_view (self);
   gtk_container_add (GTK_CONTAINER (priv->stack), view);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]